After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594664 - Popup window should use gnome-settings-daemon code
Popup window should use gnome-settings-daemon code
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on: 596136 599677 599861
Blocks:
 
 
Reported: 2009-09-09 16:18 UTC by Bastien Nocera
Modified: 2009-11-06 18:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gnome-settings-daemon popup code (67.71 KB, patch)
2009-10-27 23:35 UTC, Bastien Nocera 		none Details | Review
Use gnome-settings-daemon popup code (69.43 KB, patch)
2009-10-28 00:18 UTC, Bastien Nocera 		none Details | Review
Use gnome-settings-daemon popup code (69.44 KB, patch)
2009-10-28 00:28 UTC, Bastien Nocera 		none Details | Review
Use gnome-settings-daemon popup code (71.41 KB, patch)
2009-10-28 13:53 UTC, Bastien Nocera 		none Details | Review
Use gnome-settings-daemon popup code (71.68 KB, patch)
2009-10-29 11:18 UTC, Bastien Nocera 		none Details | Review
Use gnome-settings-daemon popup code (71.83 KB, patch)
2009-11-06 18:26 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2009-09-09 16:18:57 UTC 
Instead of copy/pasting its bugs.

See bug 538615 and bug 567249 as examples of bugs that could be avoided.

The only things that need to be done are:
- add a brightness item to GsdMediaKeysWindowAction
- add a gsd_media_keys_window_set_brightness_level() function

The rest would (should) be the same, and we can cross-pollinate bug fixes.
Comment 1 Bastien Nocera 2009-10-26 17:04:26 UTC 
Note that this would probably mean reopening bug 594585, as the code would regress (but should be an easy fix).
Comment 2 Bastien Nocera 2009-10-27 23:35:11 UTC 
Created attachment 146387 [details] [review]
Use gnome-settings-daemon popup code

Instead of forking it.
Comment 3 Bastien Nocera 2009-10-28 00:18:36 UTC 
Created attachment 146393 [details] [review]
Use gnome-settings-daemon popup code

Instead of forking it.
Comment 4 Bastien Nocera 2009-10-28 00:28:51 UTC 
Created attachment 146398 [details] [review]
Use gnome-settings-daemon popup code

Instead of forking it.
Comment 5 Bastien Nocera 2009-10-28 13:53:22 UTC 
Created attachment 146422 [details] [review]
Use gnome-settings-daemon popup code

Instead of forking it.

Also make sure the location of the popup matches
that used by gnome-settings-daemon.
Comment 6 Bastien Nocera 2009-10-29 11:18:21 UTC 
Created attachment 146492 [details] [review]
Use gnome-settings-daemon popup code

Instead of forking it.

Also make sure the location of the popup matches
that used by gnome-settings-daemon, and we switch
styles when switching compositing on/off.
Comment 7 Bastien Nocera 2009-11-06 18:26:30 UTC 
Created attachment 147120 [details] [review]
Use gnome-settings-daemon popup code

Instead of forking it.

Also make sure the location of the popup matches
that used by gnome-settings-daemon, and we switch
styles when switching compositing on/off.
Comment 8 Bastien Nocera 2009-11-06 18:30:44 UTC 
Attachment 147120 [details] pushed as d2d9057 - Use gnome-settings-daemon popup code