The code expects you to distinguish between your signature and the text of the message. I'm not sure whether it's really wrong or not. Though you can always delete that empty line before the signature (inside the dotted box) if you do not like it.

What do you think?

There are several problems with that:

1. due to some reason, in HTML mode Evolution usually puts 1 or 2 additional empty lines between the text and the signature's block (the one that includes the extra space) and these cannot be deleted (backspacing or selecting and hitting DEL does nothing to them). The extra space in the signature is just a bit too much.

2. Adding extra space after your text is easy and natural by just pressing ENTER a few more times after you finish writing. Deleting extra space on the other hand is much less natural and requires more care, especially in HTML mode where Evolution is very reluctant to delete empty lines. So if the option is to not have extra space by default and let people add what they want, or have more extra space by default and let people delete what they don't want - then I think the latter is a better option.

3. Lastly - its simply not a correct behavior: when I built my signature I didn't add an extra space in it, so adding one for me is not correct. If I wanted more space between the end of the email and the signature by default - I can go into the signature editor and add it, while the reverse cannot be done.

Created attachment 146864 [details] [review]
evo patch

for evolution;

I was afraid it'll be harder, as the change was done within bug #553535, where turning signature on and off under certain circumstances deleted message text lines, but after some testing, this change had no impact on it, thus here it is.

Created commit 64892e7 in evo master (2.29.2+)
Created commit 7e7b5a2 in evo gnome-2-28 (2.28.2+)

Thanks :-)

*** Bug 591556 has been marked as a duplicate of this bug. ***

*** Bug 606191 has been marked as a duplicate of this bug. ***