GNOME Bugzilla – Bug 553535
Signature replaces the first line of the message
Last modified: 2009-04-27 09:54:39 UTC
1 - In the Preferences Window : - Composer Preferences : In general tab, un-check the "format messages in HTML", set Reply style to "Quote original message", check "Keep Signature above the original message on replying" - In Signatures tab : create an basic text signature like : Pascal Kreyer rue du chenil 6 1300 Dully 2 - In your account setting, in the Identity tab, set signature parameter to "None" 3 - Reply to an email. No preference for the format. 4 - Insert in this new email 3 lines with text. 5 - On right side of the From scroll list, we have the signature scroll list. Select the signature from step 1 Result : the first is overwritten by the signature
Created attachment 119363 [details] [review] Add two empty lines in case the last line is overwritten by the signature
Created attachment 119365 [details] [review] rework the patch, remove <TR></TR>, so remove one empty line
a) make that a valid HTML, please (I know, it's same wrong few lines above your code, thus if you could fix that too it'll be great.) http://www.w3.org/TR/html401/struct/text.html#edef-BR b) the previous patch seems more correct there to me, because those <TR> are good to make space between the signature and the beginning of the reply. With the second patch there is no empty line between them, which makes it "hard" to distinguish between signature end and the beginning of the reply. It's not hard, actually, but looks ugly. Use the autogenerated signature, to see what I mean. c) this is a workaround, because when changing between none and autogenerated signature for few times, there are lines from the reply which are suddenly deleted. Anyway, good catch, confirming bug.
Created attachment 122098 [details] [review] proposed evo patch for evolution; This works better, even not so great as it should be. Let's wait on WebKit, how there will be solved signatures and how well this will be rewritten. Meanwhile consider this patch. Note: Signature marker is supposed to be in its own paragraph, that was the reason why it behaved so badly. I also removed some code in 'set_editor_text' function, mainly because it was buggy ( *(html+1) = ' '; removes first '-' in text, not the '\n'), and because it'll be better to let it work generally same for any setup of signature position, not "case by case" (I didn't like the skip of 'e_msg_composer_show_sig_file' call for top signatures). Some changes are supposed to come to GtkHTML, but because of the WebKit plan, I simply do not care enough :) (with top signature, in composer unset signature, set signature back by the combo, save as draft, see the source of the message, each paragraph under the signature has the 'ClueFlow' data 'signature-name' set, what a nice mess. it was doing that even before this patch.)
Seems fine to me, I didn't test though. Jeff, does this work well for you?
I tested the patch. Everything is ok except that a blank line is not added if the signature is set at the bottom of the text when replying an email.
Is it different from the way how it works without the patch? I think it's same, but I can be wrong. In case it's different, can you show me some picture, just to better understand. Thanks.
Yes, it's same. Could you make they have the same behavior in your patch?
You mean they are same now (no difference whether you run with or without the patch, when placing signature down), but would like to see new line added in the patch for bottom signatures, right?
Yes. Before applying your patch, the new line was not added for the bottom signatures. I think no matter the signature is on the top or at the bottom, the new line should be added when you reply a mail.
Created attachment 122334 [details] [review] proposed evo patch ][ for evolution; with the extra empty line when placing signature to the bottom.
How about this patch? Milan, could you commit it?
It's waiting for a review from a developer. After that I'll be more than happy to commit it and close the bug :)
Jeff, if you could confirm it works, I could push this in.
I mean an empty line needs to be inserted at the beginning of your replied mail when the signature is at the bottom. The patch didn't solve this issue.
a) you changed subject of the bug - we are trying to fix "signature is eating my mail" bug here b) why do you want there an empty line? The only possibility I can think of is when you do not bottom post. But that's really different kind of bug, or rather an enhancement.
Jeff/Milan: Any closure here?
I think this patch can be committed in and a new bug needs to be filed, an empty line should be inserted when the signature is at the bottom.
Created commit c8938bd in master. The other bug is up to you.