After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598951 - F-Spot Evolution Mail Subject
F-Spot Evolution Mail Subject
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Export
0.6.x
Other Linux
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-19 15:51 UTC by Pedro Villavicencio
Modified: 2009-12-20 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to resolve Bug 598951 (916 bytes, patch)
2009-12-19 17:39 UTC, Iain Churcher 		none Details | Review

Description Pedro Villavicencio 2009-10-19 15:51:14 UTC 
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/f-spot/+bug/454972

"When sending a photo through evolution from F-Spot, one clicks on Photo --> Send By Mail. When evolution pops up, the subject of the message is my+photos. The subject shouldn't contain a +, and the M and P should be capitalized."
Comment 1 tdjacr.foss 2009-10-19 20:49:38 UTC 
This happens on all of my Ubuntu computers, confirming.
Comment 2 Iain Churcher 2009-12-19 17:39:20 UTC 
Created attachment 150069 [details] [review]
Patch to resolve Bug 598951
Comment 3 Iain Churcher 2009-12-19 17:43:05 UTC 
This bug has been marked as an ubuntu paper cut so I thought I'd have a go at fixing it.

I traced the issue to the SendEmail.cs file where the following line was the culprit:

GtkBeans.Global.ShowUri (Dialog.Screen, "mailto:?subject=" + System.Web.HttpUtility.UrlEncode(mail_subject) + mail_attach);

The problem being that the subject was being encoded to URL via the UrlEncode method. I can see no reason for URL encoding the subject, removing this and using mail_subject directly appears to resolve the issue (tested using the above patch on Ubuntu 9.10)

This is my first ever patch to an open source project so forgive me if I have done something wrong.

Regards

Iain Churcher
Comment 4 Stephane Delcroix 2009-12-20 12:51:02 UTC 
Iain,

thx for your patch. It probably works just fine for evolution, but as evolution is handled as the "default" case, it could break some other mailers, which might require q well formatted uri.

evo should urldecode the message by itself, but as it does not, I'm ok with a workaround in f-spot, as long as it's not the default case.
Comment 5 Stephane Delcroix 2009-12-20 12:57:20 UTC 
commit ffc684bb71085f885edf2ad9af50176c5a79beca
Author: Stephane Delcroix <stephane@delcroix.org>
Date:   Sun Dec 20 13:56:39 2009 +0100

    Do not urlencode mail_subject for evo
    
    fixes bgo#598951