After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598613 - Rhythmbox shows cover art of previous track in Notification Bubble if current track has no cover art
Rhythmbox shows cover art of previous track in Notification Bubble if current...
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 597921 601944 602132 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-15 20:25 UTC by Joachim Sauer
Modified: 2010-01-16 00:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clear hints before setting icon via "icon-theme-name", patch against rhythmbox 0.12.5 (890 bytes, patch)
2009-10-24 02:07 UTC, Mirco Müller
committed Details | Review

Description Joachim Sauer 2009-10-15 20:25:32 UTC
When switching between songs while the main window is invisible notification bubble pop up to show me what the current song is.

Unfortunately the notification bubble sometimes shows the wrong cover art. When switching from a song with cover art to another song that has no cover art all the information from the new song is displayed correctly, but the cover art of the old song is still displayed (which is obviously no longer applicable).

I've reported this bug for Ubuntu already: https://bugs.launchpad.net/rhythmbox/+bug/451086

Based on the feedback of that bug report I produced a patch that solved the problem for me. It can be found here:
http://launchpadlibrarian.net/33650464/rhytmbox_notification.patch
Comment 1 Jonathan Matthew 2009-10-15 20:35:16 UTC
*** Bug 597921 has been marked as a duplicate of this bug. ***
Comment 2 Joachim Sauer 2009-10-15 20:50:45 UTC
I'm not entirely sure that that other bug is a duplicate.

I've observed two (possibly related) issues:

- switching from a track with cover art to one without cover art wrongly displays the previous tracks cover art in the notification bubble
- switching between two tracks with cover art sometimes fails to change the cover art to the new one

The first one (the one I reported with this report) is easily reproducable (happens every time) and seems to be fixed with the patch I linked to.

The other one (which I think is what the other report is about) is harder to reproduce (happens only sometimes, I didn't find out in which circumstances yet) and is *not* affected by applying my patch.
Comment 3 Mirco Müller 2009-10-24 02:07:35 UTC
Created attachment 146146 [details] [review]
clear hints before setting icon via "icon-theme-name", patch against rhythmbox 0.12.5
Comment 4 Mirco Müller 2009-10-24 02:12:15 UTC
Please ignore the above mentioned patch http://launchpadlibrarian.net/33650464/rhytmbox_notification.patch as it is not the correct way to fix this issue. Joachim might have picked up some wrong info before coming up with that patch. I'm likely to be guilty of this wrong info he got :) Sorry, Joachim!
Comment 5 Mirco Müller 2009-10-24 02:15:12 UTC
Quick copy&paste from the bug-report on launchpad for the what/why/how:

"So if a song does not have a cover-art defined for it, rb just passes a default icon via the "icon parameter". But if a previous song had a cover-art defined, it was sent from rb via DBus to the notification-daemon (notify-osd in this case) using the "image_data" hint. If this "image_data" hint is not explicitly cleared from rb before sending out that default icon as "icon parameter", the pixbuf attached to that "image_data" hint overrules the "icon parameter", resulting in the notification showing the wrong/old cover-art."
Comment 6 Jonathan Matthew 2009-10-24 02:25:47 UTC
With this explanation, it still seems odd that we'd get different behaviour from different notification services, but at least the fix makes sense.
Comment 7 Jonathan Matthew 2009-11-15 06:29:54 UTC
*** Bug 601944 has been marked as a duplicate of this bug. ***
Comment 8 Jonathan Matthew 2009-11-16 21:00:38 UTC
*** Bug 602132 has been marked as a duplicate of this bug. ***
Comment 9 Oxmosys 2010-01-16 00:45:32 UTC
According to comments in ubuntu launchpad bug report : https://bugs.edge.launchpad.net/ubuntu/+source/notify-osd/+bug/451086

This patch fixes "wrong cover" problem, but there seems to be another underlying cause why this happened : rhythmbox does not always shows cover in notification even when the cover exist. The causes of this problem are not yet identified, but many users report that rhythmbox often don't show any cover when playing.
Comment 10 Jonathan Matthew 2010-01-16 00:51:26 UTC
If you can provide any actual information about this problem, please open a new bug here.