GNOME Bugzilla – Bug 598394
Use network name for IRC account name
Last modified: 2010-09-02 10:00:31 UTC
The default name for an IRC account is something like "Pseudo on chat.freenode.net". It is prettier if that server address is replaced by the network name, so we get "Pseudo on FreeNode". That can be done in src/empathy-accounts-dialog.c::get_default_display_name(). There it should call empathy_irc_network_manager_find_network_by_address() to get the network and get the "name" property on returned EmpathyIrcNetwork object (adding a getter for it is even better).
i'm using Empathy 2.28.1 and show only the nickname for the IRC account. The problem is that I use the same nick on diferent IRC servers, so it's pretty confusing when I have to select a IRC account.
Franciso: good catch. Seems this was broken. I fixed that in the 2.28 and master branches. Xavier: the idea is good but can't easily be implemented atm as the accounts dialog isn't aware of the IRC network manager so will have to recreate one, pass it the XML files, etc. Maybe the get_display_name function should be refactored to query the account widget directly?
(In reply to comment #2) > Xavier: the idea is good but can't easily be implemented atm as the accounts > dialog isn't aware of the IRC network manager so will have to recreate one, > pass it the XML files, etc. > Maybe the get_display_name function should be refactored to query the account > widget directly? That makes sense, and it has the advantage of grouping all the special cases for different protocols in the same place.
A step in this direction has been made while fixing bug #600705. This is now done in empathy_account_widget_get_default_display_name().
Created attachment 169144 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/irc-name-598394 libempathy-gtk/empathy-account-widget-irc.c | 8 ++++++-- libempathy-gtk/empathy-account-widget-irc.h | 7 +++++-- libempathy-gtk/empathy-account-widget.c | 24 +++++++++++++++--------- libempathy-gtk/empathy-irc-network-chooser.c | 8 ++++++++ libempathy-gtk/empathy-irc-network-chooser.h | 4 ++++ 5 files changed, 38 insertions(+), 13 deletions(-)
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.