GNOME Bugzilla – Bug 600705
accounts created in the assistant don't get a nice display name
Last modified: 2011-08-29 10:12:28 UTC
They stay New <protocol> account.
Created attachment 147595 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/display-name-assistant-600705 libempathy-gtk/empathy-account-widget.c | 53 +++++++++++++++++++++++++++++++ libempathy-gtk/empathy-account-widget.h | 3 ++ src/empathy-accounts-dialog.c | 53 +----------------------------- 3 files changed, 58 insertions(+), 51 deletions(-)
Review of attachment 147595 [details] [review]: Looks good to me.
Thanks; merged to master. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. commit eac0b572a73559e88be8da3d62f15cf26d3bb1e1 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Thu Nov 12 17:19:51 2009 +0000 account-assistant: set default display name to newly created accounts (#600705) commit 2969485fc42fed028d1e8506534469b97cd5a283 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Thu Nov 12 17:15:51 2009 +0000 empathy_account_widget_get_default_display_name: special case should be done in specialized widgets This requiers to refactor widget to actually inherit from EmpathyAccountWidget. commit 07cb259462d9958e65d2f94aef6e5728e83ccf29 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Thu Nov 12 17:13:21 2009 +0000 move code generating the default display name of new account to account-widget This will allow us to: - Use this function from other places, like in the assistant. - Delegate special cases to the specialized versions of the widget.