GNOME Bugzilla – Bug 597944
[alt-tab] Separate windows in thumbnail list
Last modified: 2009-11-04 19:55:11 UTC
Created attachment 145173 [details] [review] [alt-tab] Separate windows in thumbnail list Add a separator between the windows on the current workspace and the windows on different workspaces in the thumbnail list, to indicate the windows on the current workspace (same as done for the application icons).
Created attachment 145225 [details] [review] [alt-tab] Separate windows in thumbnail list Don't show the separator if all windows are on another workspace.
Review of attachment 145225 [details] [review]: ::: js/ui/altTab.js @@ +688,3 @@ let box = new Big.Box({ padding: AppIcon.APPICON_BORDER_WIDTH + AppIcon.APPICON_PADDING }); + + if (windows[i].get_workspace() != activeWorkspace && !separatorAdded && i != 0) { What if you have an application with two windows on another workspace but no window on the current one? Reading this code, it looks like there will be a separator between both windows, as for the second window, the if's condition will be true.
Created attachment 145405 [details] [review] [AppSwitcher] Add a separator between windows in current and other workspaces. This make it is easier for the user to figure out on which workspace the windows are. For instance, terminals related to various activities and put on different workspaces were previously displayed as an uniform list, with no visible distinction between the ones from the current workspace and the others. Now they are physically separated by a thin gray line. This is also consistent with the way applications are displayed in the AppSwitcher.
Comment on attachment 145405 [details] [review] [AppSwitcher] Add a separator between windows in current and other workspaces. The patch is fine, but I don't think it actually helps at all given the near-invisibility of the separator line
Well, the visibility part is discussed in bug 597362. It at least helps when you know what you are looking for...
(In reply to comment #2) > Review of attachment 145225 [details] [review]: > > ::: js/ui/altTab.js > @@ +688,3 @@ > let box = new Big.Box({ padding: AppIcon.APPICON_BORDER_WIDTH + > AppIcon.APPICON_PADDING }); > + > + if (windows[i].get_workspace() != activeWorkspace && > !separatorAdded && i != 0) { > > What if you have an application with two windows on another workspace but no > window on the current one? Reading this code, it looks like there will be a > separator between both windows, as for the second window, the if's condition > will be true. Good catch, yeah missed that case. (In reply to comment #5) > Well, the visibility part is discussed in bug 597362. It at least helps when > you know what you are looking for... Yeah once 597362 is fixed this will be fixed too, so I wouldn't say this is a blocker.
Shall I push this patch?
(In reply to comment #7) > Shall I push this patch? I'd say yes, Dan ?
Attachment 145405 [details] pushed as dc232d4 - [AppSwitcher] Add a separator between windows in current and other workspaces.