GNOME Bugzilla – Bug 597721
Fix overview to show on the correct monitor
Last modified: 2009-11-12 22:50:26 UTC
Some notes: - I haven't actually tested on multihead. Rui Matos said that the part with changing the tween position worked for him. - It's not obvious, but getZoomedInPosition() doesn't need fixing because the windows are coming from *screen-relative* not *monitor-relative* positions. - The sizing of backOver is still wrong with this patch, so it will lap over monitors to the right of the primary monitor. It doesn't really matter - it will end up as black either way; I assume that will be cleaned up once we have Workspaces-per-monitor. - We maybe should make backOver not draw at all, since there's no point in clearing to black if the stage is black.
Created attachment 144985 [details] [review] Fix overview to show on the correct monitor When tweening the overview in, tween it to appear on the correct position of the primary monitor, not at (0,0) When the overview appears only on one monitor, we want the area outside the overview to match the overview background, so change the stage background while the overview is up. Reported by Rui Matos
(In reply to comment #0) > - The sizing of backOver is still wrong with this patch, so it > will lap over monitors to the right of the primary monitor. It > doesn't really matter - it will end up as black either way; > I assume that will be cleaned up once we have > Workspaces-per-monitor. > > - We maybe should make backOver not draw at all, since there's > no point in clearing to black if the stage is black. The intent was that backOver should cover all monitors: this._backOver.set_position(0, 0); this._backOver.set_size(global.screen_width, global.screen_height); so changing the stage color shouldn't be needed... ?
Created attachment 144989 [details] [review] Fix overview to show on the correct monitor OK, here's a patch that instead correctly positions backOver; It's more coherent than my last patch since it doesn't leave backOver randomly lapping off the right side of the monitor. (Removing backOver and changing the stage background color would be a more efficient approach since it avoids clearing the all the pixels of the screen twice.)
Comment on attachment 144989 [details] [review] Fix overview to show on the correct monitor feel free to remove backover if that would be better. i was just explaining what it was *supposed* to be doing. the positioning could use a comment exaplaining that backover's parent is positioned at primary.x, primary.y
Added the comment. Not going to fool around with deleting backOver right now. Attachment 144989 [details] pushed as a81a168 - Fix overview to show on the correct monitor
*** Bug 597081 has been marked as a duplicate of this bug. ***