After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597250 - File System appears twice
File System appears twice
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: disk list
unspecified
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-04 00:33 UTC by Andreas Nilsson
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix the issue (631 bytes, patch)
2009-10-04 23:54 UTC, Andreas Nilsson 		reviewed Details | Review
screenshot of patch in action (35.08 KB, image/png)
2009-10-04 23:54 UTC, Andreas Nilsson 		  Details

Description Andreas Nilsson 2009-10-04 00:33:31 UTC 
The word File System is mentioned twice in the same tab. First in the tab itself and then inside the tab, above the file system list. One is probably enough.
Comment 1 Andreas Nilsson 2009-10-04 22:57:34 UTC 
It seems like the label stuff is on line 313 in disks.cpp [1]
Next up, find someone who knows C!

1. http://git.gnome.org/cgit/gnome-system-monitor/tree/src/disks.cpp
Comment 2 Andreas Nilsson 2009-10-04 23:54:03 UTC 
Created attachment 144752 [details] [review]
patch to fix the issue

Here is the patch. Got some help from vuntz on jabber.
Comment 3 Andreas Nilsson 2009-10-04 23:54:59 UTC 
Created attachment 144753 [details]
screenshot of patch in action
Comment 4 Karl Lattimer 2010-03-09 23:53:24 UTC 
Review of attachment 144752 [details] [review]:

Looks good, simple removal of a duplicate label
Comment 5 Andreas Nilsson 2010-04-01 14:23:40 UTC 
Is it ok if I commit this?
Comment 6 Andreas Nilsson 2010-10-26 14:55:05 UTC 
Ping. I'm afraid of bitrots!