After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596215 - Remove gravity hack from get_updated_timeformat
Remove gravity hack from get_updated_timeformat
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-24 18:21 UTC by Behdad Esfahbod
Modified: 2009-10-06 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Behdad Esfahbod 2009-09-24 18:21:44 UTC
The comment in that function says:

        if (!safe) {
                /* FIXME: we need this for bug #410169 in pango. We'll be able
                 * to remove this at a later stage. */
                time_gravity_format = g_strdup_printf ("<span gravity=\"south\">%s</span>",
                                                       time_format);
        } else {
                time_gravity_format = g_strdup (time_format);
        }

The bug it refers to is fixed now, so this hack should be removed.  I'm guessing that this is what's causing this redhat bug:
https://bugzilla.redhat.com/show_bug.cgi?id=525371
Comment 1 Jens Petersen 2009-10-06 03:00:57 UTC
(In reply to comment #0)
> guessing that this is what's causing this redhat bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=525371

not according to https://bugzilla.redhat.com/show_bug.cgi?id=525371#c7
Comment 2 Jens Petersen 2009-10-06 03:30:05 UTC
Doing vertical text "Right" on the panel is 
not just a matter of orienting chars/words but also
the orderings of items in applets.  eg for vertical
"Applications" should appear above "Places",
and for Japanese date should appear above time.

My recommendation is drop vertical text completely for now
(at least for Japanese until it can be properly done)
unless there is a way to do this easily.
If we go that way need more input from Chinese and Korean
experts for their cases, 

But fixing the parens and time orientation glitches
would at least bring us back to the state of 2.26.
Comment 3 Behdad Esfahbod 2009-10-06 13:56:18 UTC
Jens, keep that discussion for bug 596394.  This bug is separate.
Comment 4 Vincent Untz 2009-10-06 17:43:59 UTC
I removed the hack.