After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595684 - D-Bus plugin now uses MPRIS API
D-Bus plugin now uses MPRIS API
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 640644 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-09-19 15:41 UTC by Lucky
Modified: 2011-01-26 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
D-Bus plugin patch to use MPRIS API (7.74 KB, patch)
2009-09-20 08:44 UTC, Lucky 		none Details | Review
Convert D-Bus plugin to use MPRIS API (24.99 KB, patch)
2009-09-27 19:40 UTC, Philip Withnall 		committed Details | Review

Description Lucky 2009-09-19 15:41:32 UTC 
I was modified my Totem D-Bus plugin (http://lucky.awardspace.co.uk/totem-plugins) to use standard MPRIS (http://wiki.xmms2.xmms.se/wiki/Media_Player_Interfaces) API for sending notifications.
Comment 1 Lucky 2009-09-19 16:19:59 UTC 
I'm getting error when adding attachment, so here is new version - http://lucky.sdf-eu.org/totem/dbus-service-0.3.tar.bz2
Comment 2 Philip Withnall 2009-09-20 07:03:07 UTC 
Would you be able to provide the updates as a patch for what we currently have on git head? Also, does it cover all of the MPRIS API, or just a subset? Thanks.
Comment 3 Lucky 2009-09-20 08:44:43 UTC 
Created attachment 143512 [details] [review]
D-Bus plugin patch to use MPRIS API
Comment 4 Lucky 2009-09-20 09:01:14 UTC 
It not covers all of the MPRIS API. Just only notifications of currently-playing files.
Comment 5 Philip Withnall 2009-09-27 19:40:32 UTC 
Created attachment 144132 [details] [review]
Convert D-Bus plugin to use MPRIS API

This is an updated patch from myself, which expands the plugin to implement almost all of the MPRIS API. There are a few things it can't implement unless we expose TotemPlaylist in the Python bindings, which can be the subject of another bug. Other than that, everything else in the API is there, which resulted in the expansion of the Python bindings in a few places, as well as some new helper functions in totem.h.

Bastien, are you OK with those API additions?
Comment 6 Lucky 2009-09-30 11:59:16 UTC 
Yes. I can be commited to git. May be need some testing.
Comment 7 Bastien Nocera 2009-10-22 00:11:40 UTC 
This is nice, though this should probably be written in C, and always enabled (just like the media-keys plugin)...
Comment 8 Bastien Nocera 2011-01-26 15:38:51 UTC 
*** Bug 640644 has been marked as a duplicate of this bug. ***