GNOME Bugzilla – Bug 592885
I can't differentiate sftp item and samba item in Nautilus Network
Last modified: 2012-09-19 08:37:24 UTC
Hi, Around my Ubuntu laptop (9.04) I have some Mac OSX box with ssh and samba access allowed. When I open Nautilus Network view for each Mac OSX host, I see two access item with the same label name and icon. I can't differentiate sftp item and samba item. Note : I use Nautilus 2.26.2 NEED : see some information in label and icon to see what is sftp item and samba item. Regards, Stephane
Isn't this a gio problem as the icon is retrieved by icon = g_mount_get_icon (mount); ?
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for. Thanks!
Well, NEEDINFO'ing by asking tech questions to normal users is not really useful... Reopening. harobed, does this also still happen in 2.30?
Created attachment 172088 [details] Nautilus screenshot Maybe this screenshot better explain the issue. This issue is always available with Nautilus 2.32.0 Regards, Stephane
Created attachment 222037 [details] recent shot Confirmed.
Created attachment 222060 [details] [review] Append the service name when needed to help differentiate
Review of attachment 222060 [details] [review]: ::: daemon/gvfsbackendnetwork.c @@ +162,3 @@ + { + pretty = g_strdup (_("Remote Login")); + I like the idea, but shouldn't we be consistent with the strings used in the Connect to Server dialog? (i.e. showing the protocol name instead of a more generic string)
No, I don't think so. I did not use the connect to server dialog. I'm browsing shares. We don't want to show geeky shit there if possible. On the Mac where I set the shares up they are called "Remote Login" and "File Sharing". These strings are only needed to differentiate items when you have multiple from a single server and are not normally used. BTW, I think we should change the connect to server dialog too.
Review of attachment 222060 [details] [review]: Seems like a good idea, but isn't it better to always show the service type, even if there are no conflicts? Then if say a new one is added that conflicts you know which one is the old one as it isn't renamed. ::: daemon/gvfsbackendnetwork.c @@ +203,3 @@ + { + network_file_add_service_name (prev_file); + network_file_add_service_name (file); Ís this really working for multiple conflicts? Say you have 3 Foo files. * foo1 gets inserted as Foo -> foo1. * For foo2, you get a match with foo1, so you rename both, and add a Foo (2) -> foo2. * For foo3, you get a match with foo1 (not foo2), so you rename both, and add a Foo (3) -> foo3. However, at this point foo1 will be called "Foo (1) (1)", will it not?
I think the most common case is when there is one file sharing service per host. I don't think we need to, or want to, append the service name to the user visible name by default. The second most common case is where there are multiple file sharing services per machine but using different access methods. I'm not sure there are that many cases we care about where there are multiple instances of a specific service on a specific host. But yeah it is clearly a bug that it adds the service multiple times. Have a corrected patch but need to head home to test it.
Created attachment 222267 [details] [review] Append the service name when needed to help differentiate Only append the service name to the first file once. I chose not to add a digit when there are more than two items from the same name and service because the number actually doesn't even help you identify it.
Looks good to commit.
*** Bug 605216 has been marked as a duplicate of this bug. ***