GNOME Bugzilla – Bug 592117
Calendar Printout Love
Last modified: 2010-06-16 03:54:39 UTC
Bug report to hang Pepps patch for the monthly printout to actually work as expected. Boxes will now all print the same size, and fonts will all be the same size. Overlapping issues are corrected as well.
Created attachment 142437 [details] [review] Corrections to month view printing
Created attachment 142817 [details] [review] Patch for monthly + weekly + daily printouts Path correcting various printing issues (mainly the ones reported here : http://www.go-evolution.org/CalendarPrintoutLove)
Patch looks good, I slightly modified it, as for declaration of variables in the middle of a code block, and some minor coding style differences, but nothing serious. In other words, thanks for a work. Created commit 6c9d435 in evo master (2.29.1+) Created commit 2188577 in evo gnome-2-28 (2.28.1+)
Created attachment 145503 [details] all day events out of border and quite large gaps between them
Created attachment 145504 [details] quite busy day
I would like to ask you to look on these two issues too. It's maybe only one issue, but anyway, The first PDF shows how all day events are "wasting space" and how they overlap its box (both at the top and bottom). It's more significant on the second PDF, where the space for all day events is wasted, and ordinary day events are in a very small rectangle. I would like to see smaller gaps between all day events, and no overlapping over its box (say a gap one or two points up and down the box, and one or two points between each all day event. The row height for all day events can be also smaller. Feel free to not add "[...]" bitmap on its own row, but over the last all day event. I hope these changes will help with the space in a day print.
I see and agree that there is a one pixel overlap of the boxes of the all day events. Possibly it's using the same code as the events in the hourly section, which are supposed to bump up against the line. It would look a bit cleaner if the all day events had one pixel of white space inside the box container. I see what you mean about the [...], that is a bit of space lost. I would not mind it sitting in the corner of the last all day event that fits within the space. Even as they are, they are a huge improvement over what we have now! Pepp, thoughts?
(In reply to comment #7) > Even as they are, they are a huge improvement over what we have now! Yup, definitely. And thanks for that, Pepp. > Pepp, thoughts? We had a chat on IRC with Pepp and he said he knows what I mean and will try to produce a patch.
*** Bug 563532 has been marked as a duplicate of this bug. ***
Created attachment 149753 [details] [review] All day events cleanup - reduced height of event boxes - reduced spacing between boxes - the '...' mark overlaps the last event box - add a 2px margin at the top/bottom of the all day events container
Looks good, thanks (I forgot of this last week, I'm sorry.)
Created commit 1cbedea in evo master (2.29.5+)
*** Bug 500576 has been marked as a duplicate of this bug. ***
*** Bug 548035 has been marked as a duplicate of this bug. ***
Created attachment 157703 [details] [review] weekend printing patch Dave reported one remaining issue when printing monthly calendars : Saturday events may overlap on Sunday events (when using compressed weekends option). This patch should correct this behaviour.
Thanks for a patch. Seems to work fine, thus: Created commit c0f4235 in evo master (2.31.1+) Created commit 8580bd4 in evo gnome-2-30 (2.30.1+)
*** Bug 409546 has been marked as a duplicate of this bug. ***