After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591025 - Monitor labels for gnome-display-properties are ugly
Monitor labels for gnome-display-properties are ugly
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.27.x
Other All
: Normal enhancement
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 676247 (view as bug list)
Depends on:
Blocks: randr-tracker
 
 
Reported: 2009-08-07 04:44 UTC by Christian Hergert
Modified: 2012-06-20 15:42 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Mockup of label idea (135.09 KB, image/png)
2009-08-07 04:46 UTC, Christian Hergert 		  Details
draw labels with rounded corners (4.52 KB, patch)
2009-08-10 18:48 UTC, Christian Hergert 		none Details | Review
gnome-rr: Draw monitor labels with rounded corners (3.56 KB, patch)
2012-06-20 15:40 UTC, Bastien Nocera 		committed Details | Review

Description Christian Hergert 2009-08-07 04:44:56 UTC 
They are very useful but also not as attractive as they could be.

The labels also are positioned to the top left corner which often times covers the panel for the window.  They should be placed somewhat below the panel.

When selecting a menu such as the menu bar, the menu should stay on top of the label.  Currently, the menu does, but not the menu bar.
Comment 1 Christian Hergert 2009-08-07 04:46:14 UTC 
Created attachment 140086 [details]
Mockup of label idea
Comment 2 Federico Mena Quintero 2009-08-10 17:10:07 UTC 
The code for this lives in gnome-desktop/libgnome-desktop/gnome-rr-labeler.c.  Do you want to play with a patch to improve the look of the labels?

I want to keep the color-coding, so that gnome-display-properties and the tray icon's menu can use those colors to identify their displayed monitors.
Comment 3 Christian Hergert 2009-08-10 18:48:58 UTC 
Created attachment 140362 [details] [review]
draw labels with rounded corners

Here is a small and concise patch that makes the labels have rounded corners if RGBA is available.  I still like the idea of taking it a bit further.
Comment 4 Federico Mena Quintero 2010-01-26 21:58:43 UTC 
Oops, sorry for not replying to this before!  I will check your patch soon.  Thanks for looking into this :)
Comment 5 Bastien Nocera 2012-06-20 15:40:35 UTC 
Created attachment 216848 [details] [review]
gnome-rr: Draw monitor labels with rounded corners

And make sure the rounded corner matches that of the gnome-shell panel.
Comment 6 Bastien Nocera 2012-06-20 15:41:47 UTC 
Based on your original patch, and modified to fit in our GNOME 3 world.

Attachment 216848 [details] pushed as c599163 - gnome-rr: Draw monitor labels with rounded corners
Comment 7 Bastien Nocera 2012-06-20 15:42:35 UTC 
*** Bug 676247 has been marked as a duplicate of this bug. ***