After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590558 - Add automatic zooming for fullscreen mode
Add automatic zooming for fullscreen mode
Status: RESOLVED DUPLICATE of bug 646364
Product: totem
Classification: Core
Component: Movie player
2.28.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 605230 607613 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-08-02 21:29 UTC by Robin Stocker
Modified: 2011-04-03 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mockup for fullscreen zoom buttons (308.46 KB, image/png)
2009-08-02 21:33 UTC, Robin Stocker
Details
iPhone screenshot (115.67 KB, image/jpeg)
2009-09-04 11:05 UTC, Bastien Nocera
Details

Description Robin Stocker 2009-08-02 21:29:34 UTC
The feature to zoom in (or out of) a video is mainly useful in fullscreen mode. But how can one use this feature there? I know that I can press Ctrl-Shift-1 (Ctrl-+) to use it, but the average user doesn't use such long key combinations and it's not very discoverable either. And in fullscreen, the key combination is the only way to do it.

What I'm getting at is that there should be an easy way to zoom in fullscreen mode.
Comment 1 Robin Stocker 2009-08-02 21:33:45 UTC
Created attachment 139753 [details]
mockup for fullscreen zoom buttons

This is a mockup to solve the problem. It adds two buttons for zooming at the top right, besides the "Leave fullscreen" button. The idea is that it's similar to the window buttons (minimise, maximise, close). It doesn't take too much space and is more discoverable and easy to use.

What do you think? I'll come up with a patch when we agree on the way to do it.
Comment 2 Bastien Nocera 2009-09-04 11:05:04 UTC
You can also use "R" and "T" to zoom in/out.

If we're going to add a interface to do zooming, i'd rather we added some automagic zooming, like on the iphone/ipod touch. The button would go through scaling options such as:
- original size (well, 100% zoom, no need to offer original size in fullscreen)
- clip to widest/tallest

See attached screenshot.
Comment 3 Bastien Nocera 2009-09-04 11:05:43 UTC
Created attachment 142465 [details]
iPhone screenshot
Comment 4 Robin Stocker 2009-09-04 12:13:04 UTC
How do you detect how wide/tall the real picture is? I'm thinking of videos where there are black borders in the picture itself (DVD or bad encodes for example). Are you thinking of something like mplayer's cropdetect?
Comment 5 Bastien Nocera 2009-09-04 12:37:22 UTC
I would expect most videos to have borders either on the sides, or at the top/bottom, not both. Using something like cropdetect might be a bit too heavy.
Comment 6 Robin Stocker 2009-09-04 15:35:28 UTC
Ah, I see what you mean now. I'll work out a patch for that (when I find the time).
Comment 7 Robin Stocker 2009-10-29 20:30:24 UTC
I'm coming back at this and when thinking about this, I don't like that "automagic zooming" won't work for DVDs when you want to have the top and bottom borders removed.

Maybe we need to extend the options (that the button would go through) with cropping for the usual DVD aspect ratios? (i.e. what VLC does when you choose Video -> Crop -> 16:10)
Comment 8 Bastien Nocera 2009-10-29 22:50:13 UTC
Show me DVDs with borders on the top/bottom *and* the sides.

I'm pretty certain there's very few of those, and that we'd be able to get them working using the zoom menu items/keyboard shortcuts just fine.
Comment 9 Bastien Nocera 2009-12-22 16:39:45 UTC
*** Bug 605230 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2010-01-22 22:21:37 UTC
*** Bug 607613 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2011-04-03 23:48:29 UTC
Marking as a dupe of bug 646364, which handles this already.

*** This bug has been marked as a duplicate of bug 646364 ***