GNOME Bugzilla – Bug 590503
Export meta_screen_get_startup_sequences, add change signal
Last modified: 2009-08-10 03:37:59 UTC
It's useful for plugins to be able to get access to the startup-notification data that Mutter already has. Add an accessor and change signal.
Created attachment 139714 [details] [review] Export meta_screen_get_startup_sequences, add change signal
I can see how this would be useful; in the moblin plugin I have SN monitor callback, and having a signal with easy access to the data would make things nicer. However, I think we need two signals here starup-sequence-added and startup-sequence-remove, or at least a bool parameter to the single signal indicating whether this the type of change (there is no easy way to differentiate this otherwise). Also, could we mention in the documentation for the new function, that both the GSList and the data it contains are owned by the Window Manger and must not be modified?
Sorry, having had some breakfast and coffee, having two signals would not work satisfactorily here either: I would like to be able to differentiate at least between the initiated, completed and canceled events, and also to be able to tell which application triggered this even -- I am looking for a single signal as in the patch, but with the SnStartupSequence object as a parameter (for the removed case, we need to take care not to release our reference on the object too early). (Unfortunately I just discovered that although the SnStartupSequence object has internally a canceled flag, it does not provide a public accessor for this; I will file a bug against libsn for this.)
Created attachment 139819 [details] [review] Export meta_screen_get_startup_sequences, add change signal It's useful for plugins to be able to get access to the startup-notification data that Mutter already has. Add an accessor and change signal.
Created attachment 139825 [details] [review] Export meta_screen_get_startup_sequences, add change signal It's useful for plugins to be able to get access to the startup-notification data that Mutter already has. Add an accessor and change signal when recieve an event.
There is some trailing whitespace in the patch, other than that it looks good to commit.
Pushed, thanks!