After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590503 - Export meta_screen_get_startup_sequences, add change signal
Export meta_screen_get_startup_sequences, add change signal
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 590429
 
 
Reported: 2009-08-02 04:44 UTC by Colin Walters
Modified: 2009-08-10 03:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Export meta_screen_get_startup_sequences, add change signal (3.20 KB, patch)
2009-08-02 04:44 UTC, Colin Walters
none Details | Review
Export meta_screen_get_startup_sequences, add change signal (3.61 KB, patch)
2009-08-03 20:14 UTC, Colin Walters
none Details | Review
Export meta_screen_get_startup_sequences, add change signal (3.83 KB, patch)
2009-08-03 20:32 UTC, Colin Walters
reviewed Details | Review

Description Colin Walters 2009-08-02 04:44:22 UTC
It's useful for plugins to be able to get access to the
startup-notification data that Mutter already has.  Add
an accessor and change signal.
Comment 1 Colin Walters 2009-08-02 04:44:25 UTC
Created attachment 139714 [details] [review]
Export meta_screen_get_startup_sequences, add change signal
Comment 2 Tomas Frydrych 2009-08-02 07:51:04 UTC
I can see how this would be useful; in the moblin plugin I have SN monitor callback, and having a signal with easy access to the data would make things nicer. However, I think we need two signals here starup-sequence-added and startup-sequence-remove, or at least a bool parameter to the single signal indicating whether this the type of change (there is no easy way to differentiate this otherwise). Also, could we mention in the documentation for the new function, that both the GSList and the data it contains are owned by the Window Manger and must not be modified?
Comment 3 Tomas Frydrych 2009-08-02 08:30:48 UTC
Sorry, having had some breakfast and coffee, having two signals would not work satisfactorily here either: I would like to be able to differentiate at least between the initiated, completed and canceled events, and also to be able to tell which application triggered this even -- I am looking for a single signal as in the patch, but with the SnStartupSequence object as a parameter (for the removed case, we need to take care not to release our reference on the object too early).

(Unfortunately I just discovered that although the SnStartupSequence object has internally a canceled flag, it does not provide a public accessor for this; I will file a bug against libsn for this.)
Comment 4 Colin Walters 2009-08-03 20:14:48 UTC
Created attachment 139819 [details] [review]
Export meta_screen_get_startup_sequences, add change signal

It's useful for plugins to be able to get access to the
startup-notification data that Mutter already has.  Add
an accessor and change signal.
Comment 5 Colin Walters 2009-08-03 20:32:51 UTC
Created attachment 139825 [details] [review]
Export meta_screen_get_startup_sequences, add change signal

It's useful for plugins to be able to get access to the
startup-notification data that Mutter already has.  Add
an accessor and change signal when recieve an event.
Comment 6 Tomas Frydrych 2009-08-04 07:55:01 UTC
There is some trailing whitespace in the patch, other than that it looks good to commit.
Comment 7 Colin Walters 2009-08-10 03:37:59 UTC
Pushed, thanks!