GNOME Bugzilla – Bug 590429
implement active application area
Last modified: 2010-04-12 22:07:15 UTC
We should have some story on startup notification. Random ideas: * Flashing app icon next to Activities * A Chrome (the browser)-like transient overlay status line in the bottom left
Created attachment 139715 [details] [review] Bug 590429 - Display startup notification This is a cut at some form of startup notification; we display a pulsing icon next to Activities.
Should be application based and follow the design here http://www.gnome.org/~mccann/shell/design/GNOME_Shell-20090705.pdf
doesn't work with the current 590503 patch
Created attachment 140084 [details] [review] panel: Switch to fully dynamic layout There was lots of fixed positioning in the Panel; now it is completely dynamic, and width/height is driven from main.js. We still have a global constant Panel.PANEL_HEIGHT, but this is a big step towards eliminating it. Also, this avoids overdraw in the "way too many tray icons" case. The clock will shift left.
Created attachment 140085 [details] [review] Application menu area Initial application menu area; just displays active application window.
*** Bug 590495 has been marked as a duplicate of this bug. ***
Created attachment 140087 [details] [review] Application menu area Add an application menu area which displays the currently active application, and also displays startup notification. When launching an app, de-focus the current window, as per the design.
Created attachment 140365 [details] [review] panel: Switch to fully dynamic layout rebase around the hotspot changes
Created attachment 140366 [details] [review] Application menu area rebase
(In reply to comment #8) > Created an attachment (id=140365) [edit] > panel: Switch to fully dynamic layout Seems a little odd to be fully implementing height-for-width allocation, etc, when the design has a fixed size, but ok. + childBox.x1 = box.x2-rightWidth; whitespace (In reply to comment #9) > Created an attachment (id=140366) [edit] > Application menu area + Main.overlay.connect('shown', Lang.bind(this, function () { + this.actor.opacity = 192; + })); might be better to use 'showing', so that it fades when the overview *starts* animating in, rather than when it finishes. + _startPulseDown: function(box) { + Tweener.addTween(box, { time: 0.5, opacity: 16, transition: "easeOutQuad", + _startPulseUp: function(box) { + Tweener.addTween(box, { time: 0.5, opacity: 255, transition: "easeOutQuad", it would probably look better if you use an InOut transition here (eg, "easeInOutQuad") so that the opacity follows a sinusoidal curve rather than a wave-shaped one + (GBoxedCopyFunc)sn_startup_sequence_ref, sn_startup_sequence_ref() is void, so can't be used directly as a copy func +/** + * sn_startup_sequence_create_icon: wrong function name (s/sn/shell/) which makes gir-scanner ignore it, which makes the (transfer none) annotation be ignored, which makes it crash if you launch the same app twice. After fixing those two things it works and looks good to me.
Thanks for the review.