After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589851 - append the body to notification instead of overwriting it
append the body to notification instead of overwriting it
Status: RESOLVED DUPLICATE of bug 607446
Product: empathy
Classification: Core
Component: Notifications
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on: 601691
Blocks:
 
 
Reported: 2009-07-27 10:32 UTC by Nicolò Chieffo
Modified: 2010-01-19 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
append_notification_body.patch (1.49 KB, patch)
2009-07-27 10:46 UTC, Nicolò Chieffo
rejected Details | Review

Description Nicolò Chieffo 2009-07-27 10:32:47 UTC
I prepared a patch (though I don't know if it's correct) which appends the body text to a notification instead of replacing it.

I thought of this because when the notification is updated, there might be not enough time to see the previous message. so appending it is in my opinion better
Comment 1 Nicolò Chieffo 2009-07-27 10:46:42 UTC
Created attachment 139270 [details] [review]
append_notification_body.patch
Comment 2 Frederic Peters 2009-07-27 10:48:44 UTC
Will this work with all notification daemons, or should capabilities be tested?
Comment 3 Nicolò Chieffo 2009-07-27 10:51:06 UTC
It is not a capability, I simply append the text using g_strdup_printf
Comment 4 Guillaume Desmottes 2009-07-28 17:06:32 UTC
How do you manage the following case:
- Alice sends you "a first message"
- Bob sends you "a second message"

Are the 2 messages mixed in the same notification?
Comment 5 Nicolò Chieffo 2009-07-28 18:01:09 UTC
They don't mix, anyway only the bubble from Alice is displayed (not the second from Bob), because of this "bug" (it's an intentional behavior): http://bugzilla.gnome.org/show_bug.cgi?id=589868

The bubble from Bob will be displayed as soon as clicking on the blinking notification area
Comment 6 Nicolò Chieffo 2009-09-05 17:11:40 UTC
Any intention about the patch? reject?
Comment 7 Praveen Thirukonda 2009-10-02 13:24:07 UTC
+1. pls get this in. it would be a greeat usability improvement.
Comment 8 Guillaume Desmottes 2009-10-02 15:31:04 UTC
FYI bug #597125 slightly changes the notifications bubbles behaviour.
Comment 9 Guillaume Desmottes 2009-11-12 13:43:19 UTC
I think this make sense but should be done only if the server supports the 'append' capability. This should be implemented on the EmpathyNotifyManager (bug #601691) is merged.
Comment 10 Guillaume Desmottes 2010-01-19 16:09:29 UTC
Closing a dup of bug #607446 as it provides a better patch.

*** This bug has been marked as a duplicate of bug 607446 ***