After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597125 - libnotify chat bubbles aren't displayed once the first bubble disappeared
libnotify chat bubbles aren't displayed once the first bubble disappeared
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Notifications
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-02 14:57 UTC by Guillaume Desmottes
Modified: 2009-10-03 10:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixed in http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/popup-bubble-597125 (673 bytes, patch)
2009-10-02 15:12 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2009-10-02 14:57:48 UTC
Consider the following scenario:
- You receive a message from Alice : "one"
- A libnotify bubble is displayed containing "one"
- Right after you receive a second message from here: "two"
- The bubble is updated and now display "two"
- You don't accept the chat and wait a bit. The notify bubble disappears.
- Alice sends you a new message "three"
- No bubble is displayed this time

There is no reason for that; we should display a new bubble in that case.
Comment 1 Guillaume Desmottes 2009-10-02 15:12:56 UTC
Created attachment 144600 [details] [review]
fixed in http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/popup-bubble-597125

 src/empathy-event-manager.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
Comment 2 Guillaume Desmottes 2009-10-02 15:17:39 UTC
Merged to master.

commit abb123fcefb5ca1ecdeeb8ca2813de20da9f7e09
Author: Rob Bradford <rob@linux.intel.com>
Date:   Fri Oct 2 16:04:10 2009 +0100

    Bring up notifications until the conversation is accepted (#597125)
    
    Rather than filter out message received signals for new conversations
    that have already been tried to be initiated let them pass through. This
    results in you getting notifications repeatedly until you open accept the
    conversation and open the conversation window with the user.
Comment 3 Guillaume Desmottes 2009-10-03 10:47:17 UTC
This fix has been merged to the 2.28 branch as well.