After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589817 - cancel accidental movement when double-clicking on a curve
cancel accidental movement when double-clicking on a curve
Status: VERIFIED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal blocker
: 0.13.2
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-26 22:04 UTC by Jean-François Fortin Tam
Modified: 2009-08-12 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-07-26 22:04:00 UTC
When double-clicking a keyframe curve (to add a keyframe) or double-clicking an existing keyframe, usually, the keyframe will be displaced slightly (as a result of the mechanical nature of a human hand clicking on a mouse and displacing it slightly in the process).

I would like this movement to be cancelled out. Only move when doing a drag or when resulting from a manual value change (bug #589815).
Comment 1 antistress 2009-07-26 22:30:26 UTC
Ideed, adding a keyframe by double-clicking the curve breaks the curve
Comment 2 Edward Hervey 2009-07-27 09:53:25 UTC
This should be easy to fix:

When double-clicking to add a curve:
* Take the current x position of the mouse (i.e. the time position)
* Figure out what value the curve is at for that time position
* Add a new keyframe with those calculated time-position/value

Basically... don't take into account the y position but calculate it.
Comment 3 Brandon Lewis 2009-08-04 00:01:01 UTC
commit ed0173e51511642f0d228856e1186e6a6d172114
Author: Brandon Lewis <brandon_lewis@berkeley.edu>
Date:   Mon Aug 3 16:52:53 2009 -0700

    track.py, curve.py: when creating keyframes, calculate value so that it lies
    on the existing curve. fixes bug 589815

note: used incorrect bug number in commit message, unsure what to do about that now that it's been committed to master.
Comment 4 Jean-François Fortin Tam 2009-08-04 22:27:41 UTC
It even passes the wacom stylus test. Bulletproof.
Comment 5 antistress 2009-08-05 22:04:30 UTC
i've just made a quick test of the updated PPA version (thanks for that BTW) :
I don't know if it's related but it's way harder now to delete a keyframe by clicking again on it
It tends to add another keyframe
Comment 6 antistress 2009-08-12 15:15:14 UTC
concerning my above comment, i've created Bug 591571