After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589815 - Allow manually inputting values for a keyframe
Allow manually inputting values for a keyframe
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: Keyframes animation
0.91
Other Linux
: Normal enhancement
: 0.95
Assigned To: Mathieu Duponchelle
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-26 22:01 UTC by Jean-François Fortin Tam
Modified: 2015-10-20 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2009-07-26 22:01:19 UTC
Double-clicking an existing keyframe should allow setting its position by typing into a popup gtk spinbox widget.
Comment 1 antistress 2009-07-26 22:26:06 UTC
Do users really need to manually input values for a keyframe ?
As far as i'm concerned, i like the graphical way to set volume with curves by moving keyframes with my mouse pointer, and i don't need to set something as accurate as 17% or 14%
Comment 2 antistress 2009-07-26 22:26:39 UTC
Besides double-clicking an existing keyframe actually removes it
Comment 3 antistress 2009-07-26 22:39:00 UTC
Concerning the double-click result, see also Bug 589819
Comment 4 Jean-François Fortin Tam 2009-07-27 03:46:02 UTC
Well, some more arguments
- I'm certain power-users will ask for being able to input a precise value (heck, I've seen some power users asking to be able to set the duration of a transition manually!)
- if you want to make the curve between two keyframes "flat", you need to be able to set the values of those two keyframes to be the same.
- users probably won't use values such as 13% or 17% or stuff like that, but 50% or 70% or 20% would be pretty common, I would guess (especially for video compositing opacity)
Comment 5 Edward Hervey 2009-07-27 09:33:05 UTC
This is definitely bordering into pro/power user-land...

The in-source keyframes are meant to allow fast/convenient/rough volume editing which should be sufficient for most users. Also... you're basically limited to only one 'curve' being displayed at all time.

For all those power/extra cases (where you need precise/extended control) ... I was thinking that we could have a mode by which the full curves would appear below the source.

* normal:
-------------------
|     Source      |
-------------------

* extended:
-------------------
|     Source      |
-------------------
|   Volume curve  |
-------------------
|     Pan curve   |
-------------------

Why display them below ? Well the curves need to stay in sync with the rest of the source(s)/timeline. Like this you can see your curves in sync with everything else.

As for this specific bug issue... if we display the current percentage/value applied next to all nodes... you should be able to modify the value more precisely.
Comment 6 Jean-François Fortin Tam 2009-07-27 13:13:37 UTC
I may have a simpler solution to the multiple curves problem... what if we had, on the timeline toolbar, a gtk combobox widget for switching between which curves are displayed (well, 2 comboboxes: 1 for video, 1 for audio). One would then be able to switch between "None", "Volume", "Pan", with the flick of a mousewheel.
Comment 7 antistress 2009-07-27 14:07:08 UTC
I prefer having curves on source than below
i don't see what are the advantages of displaying them below whereas it takes more space
Comment 8 Brandon Lewis 2009-08-03 23:24:42 UTC
just wait until we have effect objects with 10 interpolated property curves. At that point, you'll need a way to separate them so you can more easily tweak the property in which you're interested. 
Comment 9 antistress 2009-08-03 23:55:26 UTC
you mean one curve by track and then 10 effects tracks below the video track for instance ? if yes, i don't think that PiTiVi can be played on standards monitors.

an alternative would be something inspired by GIMP layers : offer the possibilty to display/hide each curve on the same (video or audio) track
Pros : save space
Cons : can't set easily up one curve by imitating another one
Comment 10 Brandon Lewis 2009-08-04 01:12:07 UTC
we have these widgets called vertical scroll bars...

in any case I think we might need two expanded modes: one with the curves overlapping each other (i.e. on the same coordinate plane), and another with the curves on separate (necessarily shorter) planes.
Comment 11 Thibault Saunier 2015-10-20 13:18:06 UTC
This bug has been migrated to https://phabricator.freedesktop.org/T2296.

Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi.

See http://wiki.pitivi.org/wiki/Bug_reporting for details.