After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589117 - Remove deprecated libgnome(ui) dependency
Remove deprecated libgnome(ui) dependency
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
Depends on: 571237 588877
Blocks:
 
 
Reported: 2009-07-20 11:04 UTC by André Klapper
Modified: 2009-08-23 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove gnome-macros.h (6.01 KB, patch)
2009-07-20 12:29 UTC, Gerd Kohlberger 		none Details | Review
Cleanup generic libgnomeui includes to be more specific (2.18 KB, patch)
2009-07-30 11:42 UTC, André Klapper 		none Details | Review
Remove libgnome & libgnome-ui (37.45 KB, patch)
2009-08-04 16:11 UTC, Gerd Kohlberger 		committed Details | Review

Description André Klapper 2009-07-20 11:04:38 UTC 
This is required for GNOME 3.

http://live.gnome.org/LibgnomeMustDie

./gok/test-gok-wordcomplete.c:#include <libgnomeui/libgnomeui.h>
./gok/main.c:#include <libgnomeui/libgnomeui.h>
./gok/test-gok-action.c:#include <libgnomeui/libgnomeui.h>
./gok/test-gok-feedback.c:#include <libgnomeui/libgnomeui.h>
./gok/gok-page-keyboard.c:#include <libgnomeui/libgnomeui.h>

./gok/main.c:#include <libgnomeui/gnome-client.h>

./gok/gok-key.c:#include <libgnome/gnome-program.h>
./gok/main.c:#include <libgnome/gnome-program.h>

./gok/gok-utf8-word-complete.c:#include <libgnome/gnome-macros.h>
./gok/gok-sliding-window-word-complete.c:#include <libgnome/gnome-macros.h>
./gok/word-complete.c:#include <libgnome/gnome-macros.h>
./gok/gok-word-complete.c:#include <libgnome/gnome-macros.h>
Comment 1 Gerd Kohlberger 2009-07-20 12:28:17 UTC 
Patch to use G_DEFINE_TYPE instead of GNOME_BOILERPLATE_. Removes all gnome-macros.h includes.

./gok/gok-utf8-word-complete.c:#include <libgnome/gnome-macros.h>
./gok/gok-sliding-window-word-complete.c:#include <libgnome/gnome-macros.h>
./gok/word-complete.c:#include <libgnome/gnome-macros.h>
./gok/gok-word-complete.c:#include <libgnome/gnome-macros.h>
Comment 2 Gerd Kohlberger 2009-07-20 12:29:24 UTC 
Created attachment 138813 [details] [review]
Remove gnome-macros.h
Comment 3 André Klapper 2009-07-20 13:23:02 UTC 
For your interest, I've mostly listed one bug report/example patches of other fixed modules at http://live.gnome.org/AndreKlapper/GCDS3 .
Maybe it can be a bit helpful too to look at code of other projects...
Comment 4 André Klapper 2009-07-30 11:42:23 UTC 
Created attachment 139555 [details] [review]
Cleanup generic libgnomeui includes to be more specific

Trying to get rid of the generic <libgnomeui/libgnomeui.h> headers to see what exact parts need to be substituted.
Comment 5 Gerd Kohlberger 2009-08-04 16:11:06 UTC 
Created attachment 139875 [details] [review]
Remove libgnome & libgnome-ui

Here's a combined patch that removes everything listed in comment #1 and updates the build files. Thanks for all your help André.
Comment 6 Gerd Kohlberger 2009-08-04 16:17:41 UTC 
well the list above comment #1 actually. :)
Comment 7 André Klapper 2009-08-07 15:25:27 UTC 
I'd really like to see this getting in for the next tarball (2.27.90, August 10) so this receives enough testing for 2.28.

David, can you review this?
Comment 8 David Bolter 2009-08-08 17:53:35 UTC 
Comment on attachment 139875 [details] [review]
Remove libgnome & libgnome-ui

Thanks.
Comment 9 Gerd Kohlberger 2009-08-10 20:07:34 UTC 
Committed to master. Thanks for the review.