GNOME Bugzilla – Bug 588877
Cleanup <gnome.h> includes
Last modified: 2009-07-20 11:06:53 UTC
gok has lots of "#include <gnome.h>" lines. Most of them don't make sense, and they also hide the complexity of the task to get rid of libgnome(ui) for GNOME3. http://live.gnome.org/LibgnomeMustDie Hence I removed *all* of these includes and tried to get gok to build again by adding step-by-step those missing headers that are really required. Patch attached - please carefully review as I am not a coder. After that we can start to get rid of libgnome(ui) which should be not that hard according to what I have seen so far.
Created attachment 138590 [details] [review] Patch
Also CC'ing Gerd here. Feedback and testing of the patch HIGHLY welcome.
gok-action.c shows a few "incompatible implicit declaration of built-in function ‘strlen’" warnings. This can be fixed by including <string.h> in gok-action.c. Otherwise the patch looks fine. Thanks André.
Thanks for the quick review and sorry for not checking the output intensively. Implementing http://live.gnome.org/GnomeGoals/NicerBuilds might help. Committed with the change you required: http://git.gnome.org/cgit/gok/commit/?id=4b405e5a308862c18a6c8838669da2fcd6cc593f If there's any other issues anybody runs into: Feel free to fix. I am going to file a bug about the remaining "real" libgnome(ui) deprecation work later on and add a dependency on this one.
Garr. Correcting patch status.