After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588260 - nicer card backs and jokers for the default card theme
nicer card backs and jokers for the default card theme
Status: RESOLVED OBSOLETE
Product: aisleriot
Classification: Other
Component: artwork
git master
Other All
: Normal enhancement
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks:
 
 
Reported: 2009-07-10 16:38 UTC by Andreas Nilsson
Modified: 2021-06-02 11:38 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
current look (107.96 KB, image/png)
2009-07-10 16:38 UTC, Andreas Nilsson
  Details
Screenshot up updated graphics (871.16 KB, image/jpeg)
2009-07-10 16:39 UTC, Andreas Nilsson
  Details
gnomangelo_bitmap with new back artwork (764.42 KB, image/svg+xml-compressed)
2009-07-10 21:31 UTC, Mads Rosendahl
  Details
card back svg (403.72 KB, image/svg+xml)
2009-07-11 20:13 UTC, Mads Rosendahl
  Details
updated file (459.35 KB, patch)
2009-07-12 21:46 UTC, Christian Persch
none Details | Review
Replace GNOME foot on card artwork (481.38 KB, patch)
2013-03-03 23:11 UTC, William Jon McCann
committed Details | Review

Description Andreas Nilsson 2009-07-10 16:38:03 UTC
Please describe the problem:
The current card back graphics sports a GNOME foot. I think it's desirable to get rid of that logo and replace it with something that looks more like actual playing cards.
Mads recently sent me some really neat graphics for this and it looks amazing.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Andreas Nilsson 2009-07-10 16:38:28 UTC
Created attachment 138206 [details]
current look
Comment 2 Andreas Nilsson 2009-07-10 16:39:39 UTC
Created attachment 138207 [details]
Screenshot up updated graphics
Comment 3 Mads Rosendahl 2009-07-10 21:31:14 UTC
Created attachment 138220 [details]
gnomangelo_bitmap with new back artwork

I've created a version of gnomangelo_bitmap with the new back artwork. Though there seems to be a problem with the border of the card back (can't figure it out!).
Not sure if this is a problem too, but the size has gone up and is now at 764,4 KB! Might be essential for some distributions to keep the same size in order to fit everything on a LiveCD.

I've included the jokers from David Bellot's SVG cards (http://david.bellot.free.fr/svg-cards/).
Comment 4 Christian Persch 2009-07-11 11:56:01 UTC
Looks very nice; thanks!

Removing the Gnome foot was also suggested in bug 586560 comment 3; I'm all for it.

The size increase is probably due to having edited the file using inkscape or sodipodi. The gnomangelo_bitmap.svg origin file was specially treated to remove all the cruft these editors add.

To fix that, you should first run xmllint on the new file, then create a copy of the old file and just copypaste the definitions of the back and the jokers from the new file into the copy, in a _text editor_. Finally, remove any extra sodipodi or inkscape tags/attributes from the new cards, if any.

The "JOKER" text uses Bitstream Vera Serif; this should probably be changed to DejaVu Serif.

I compared the rendering times between the old and the new back; they seem pretty close together, so there shouldn't be a problem there.

Comment 5 Mads Rosendahl 2009-07-11 20:13:38 UTC
Created attachment 138247 [details]
card back svg
Comment 6 Mads Rosendahl 2009-07-11 20:23:25 UTC
Christian Persch -> Thanks for the reply.

I must be honest and admit that I have no idea what you are talking about regarding the fix.
Would you/someone care to make the necessary adjustments? I'm just learning Inkscape (and Linux).
Comment 7 Christian Persch 2009-07-12 21:46:17 UTC
Created attachment 138300 [details] [review]
updated file

Using the method in my comment above, I get this new file.

It's still twice the size of the old file, almost solely due to the detailed back graphics. (Gzip'd it's a bit smaller than the old un-gzip'd one.)

Since the back graphics has obvious repetitions, I think the size could be greately reduced if you just made a <g> for one of the elements, and then used <use> to create the 5 rows of 3 columns of the element? That would reduce it to 1/15th of the size increase without increasing the rendering time. That would take the increase due to the #back card to about 30k, which would be totally fine.
Comment 8 Christian Persch 2009-08-13 13:52:04 UTC
Deferring this due to the size increase. Comment 7 explains how the size increase can be limited to acceptable levels.
Comment 9 William Jon McCann 2013-03-03 23:11:45 UTC
Created attachment 237914 [details] [review]
Replace GNOME foot on card artwork

This adds a new design for the card back artwork and replaces
the jokers with those from David Bellot's SVG cards.


Update to master.
Comment 10 William Jon McCann 2013-03-03 23:13:04 UTC
Now that we use svgz by default and the zipped version of the deck is approximately the same as before I think we should consider putting this in.
Comment 11 Christian Persch 2013-03-04 21:01:31 UTC
Comment on attachment 237914 [details] [review]
Replace GNOME foot on card artwork

Committed this one to git, but that doesn't do anything for all the other themes that still have the foot (esp. the default one which is 'bonded' right now).
Comment 12 GNOME Infrastructure Team 2021-06-02 11:38:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/aisleriot/-/issues/122.