GNOME Bugzilla – Bug 586560
Aislerot should support branding
Last modified: 2012-01-31 23:14:22 UTC
From launchpad: https://bugs.launchpad.net/ubuntu/+source/gnome-games/+bug/390324 Aislerot should support branding for its artwork: https://wiki.ubuntu.com/branding We already have some artwork made, all that's needed is for aislerot to prefer /usr/share/branding rather than /usr/share for it's artwork, when it exists. Thanks!
The branded background is really ugly and distracts from the cards. I recommend we don't fix this, at least for backgrounds.
I'm totally opposed to any "branding". It's just dull, mindless stamping of your "brand" on every surface; there's nothing creative about it. It's as necessary as the pee that dogs leave on every tree and corner. Not to mention that what the user gets is not actually '_Ubuntu_ Aisleriot'; it's plain old Aisleriot. Technically speaking, I don't see any need for any patches. A 'ubuntu-branding' pkg could just dpkg-divert those graphics files from the gnome-games pkg, instead of making the programme look in extra paths. And if you want to add new card themes, they can just go in the standard path and you just have to add a patch that makes them the default. IMNSHO this is WONTFIX; but I'll leave the bug open for a few days in case the other gnome games developers want to put their view forward.
Christian, I entirely agree with your opinion on unnecessary branding. :-) Given that, perhaps the foot branding could disappear from the card backs, Nibbles intro screen, Mahjongg tiles etc? Removing the branding altogether would be even better than trying to change one brand to another.
I wouldn't be opposed to that. If someone can do a nice, simple graphic, that - does NOT increase loading or rendering time - works for the Jokers too (or do a separate dessin for them). Note that there are also more card themes in gnome-games-extra-data that would need to be similarly modified, since I want to keep them uniform with the default theme. (BTW: needs to take care not to bloat the file either. E.g. I noticed that ubuntu-brandings's gnomangelo_bitmap ubuntified default theme is twice the size of our own gnomangelo_bitmap default theme, even though only the foot graphic was exchanged! So while the work can be done in inkscape / sodipodi, the final assembly needs to be done by hand.) For gnibbles etc. you'd have to file separate bugs.
I've thought about this a bit and I agree that dpkg-diversions are a better solution here. I had originally envisioned having both cardsets available (and thus selectable), however replacement is probably a better general solution.
As already noted in comment 4, you don't need to divert the card theme; you can simply install your variant under another name and patch the default. Just for reference, branding has been discussed previously on the mailing list, e.g. http://mail.gnome.org/archives/games-list/2006-May/msg00012.html and http://mail.gnome.org/archives/games-list/2007-August/msg00002.html . I also want to note that the gnomangelo card theme is GPL (see http://mail.gnome.org/archives/games-list/2008-January/msg00020.html ), so ubuntu-branding's gnomanglo variant is too, and it contains the (trademarked) ubuntu logo. I'm unsure how that's compatible with their trademark policy [http://www.ubuntu.com/aboutus/trademarkpolicy] ...
We can't patch the default card theme without modifying the aislerot package, and the intent is for there to be multiple different branding packages (or none at all) that are friendly to derivatives.
Re comment 3: removing the Gnome foot from the cards is being done in bug 588260.
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component. Apologies for the mass email!