After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587219 - liveadder: merge into adder or audiomixer
liveadder: merge into adder or audiomixer
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-28 16:41 UTC by kxra
Modified: 2015-03-14 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description kxra 2009-06-28 16:41:37 UTC
Request to move liveadder from -bad to -good
Comment 1 kxra 2009-07-01 00:28:50 UTC
Moving rtpmanager is also needed 
http://bugzilla.gnome.org/show_bug.cgi?id=521625

Specifically, this will help Empathy
https://bugs.launchpad.net/bugs/388898
Comment 2 Olivier Crête 2009-07-01 03:13:50 UTC
Lets make this into a bug to move the rest of the plugins needed by farsight2:

 - autoconvert
 - dtmf
 - liveadder
 - rtpmux
 - valve

For msnwebcam, we'll also want to move ext/mimic to -ugly

Code quality wise, all of these should be ready to move, they are only missing unit tests.

That said, there is no point moving them before rtpmanager is ready.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-07 18:45:42 UTC
For liveadder, is it the latency-parameter that sets the max-timeout for the mixing? If so that could be linked from the section-docs.

Also none of the elements have unit-tests. Even a very basic test wuld be enough to e.g. get valgrind coverage.
Comment 4 Tim-Philipp Müller 2010-09-28 09:56:08 UTC
> Lets make this into a bug to move the rest of the plugins needed by farsight2:

As discussed on IRC a while back, please file one bug per plugin you want moved. That's much more managable. Most of these plugins look like it shouldn't be a problem to get them moved, but it's easier to do ten things one-by-one.
Comment 5 Sebastian Dröge (slomo) 2010-09-28 10:01:45 UTC
And it should really be done soon because distros already have interesting hacks to move these plugins to -good for empathy...
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2010-09-28 10:42:10 UTC
Adding dependency for the separate rtpmux moving ticket.

Imho autoconvert, value could even go to core. We might need autoconvert in playbin2 for doing e.g.ac3 passthrough.

For dtmf there is bug #607321.

Regarding liveadder, it would be nice to check if the elemnt could be moved to the adder plugin to share code.

I totally agree with having different bugs to discuss the needed improvements separately.
Comment 7 Olivier Crête 2010-09-28 16:01:59 UTC
The reason I didn't file bugs is that I wanted to review them myself for all the smallish stuff before doing that. And also write unit tests for those that don't yet have them. And I've been lazy...
Comment 8 Olivier Crête 2010-09-28 16:07:34 UTC
Also, liveadder should probably use GstCollectPads2 at some point (bug #532944) that were added into the new video mixer.
Comment 9 Sebastian Dröge (slomo) 2013-08-21 18:14:10 UTC
And ideally adder would support that itself, same as videomixer.
Comment 10 Olivier Crête 2013-08-21 18:36:23 UTC
The liveadder functionality should be merged into adder, collectpads2 should make that a bit easier already.
Comment 11 Sebastian Dröge (slomo) 2014-01-06 09:21:54 UTC
Yes, also the flushing support for collectpads I'm currently working on will make this easier too (because thread decoupling of inputs and output)
Comment 12 Tim-Philipp Müller 2015-03-14 14:19:34 UTC
I think we can close this. The audiomixer in -bad should support all of this now, and if not please file specific bugs with missing features against it instead.