GNOME Bugzilla – Bug 587219
liveadder: merge into adder or audiomixer
Last modified: 2015-03-14 14:19:34 UTC
Request to move liveadder from -bad to -good
Moving rtpmanager is also needed http://bugzilla.gnome.org/show_bug.cgi?id=521625 Specifically, this will help Empathy https://bugs.launchpad.net/bugs/388898
Lets make this into a bug to move the rest of the plugins needed by farsight2: - autoconvert - dtmf - liveadder - rtpmux - valve For msnwebcam, we'll also want to move ext/mimic to -ugly Code quality wise, all of these should be ready to move, they are only missing unit tests. That said, there is no point moving them before rtpmanager is ready.
For liveadder, is it the latency-parameter that sets the max-timeout for the mixing? If so that could be linked from the section-docs. Also none of the elements have unit-tests. Even a very basic test wuld be enough to e.g. get valgrind coverage.
> Lets make this into a bug to move the rest of the plugins needed by farsight2: As discussed on IRC a while back, please file one bug per plugin you want moved. That's much more managable. Most of these plugins look like it shouldn't be a problem to get them moved, but it's easier to do ten things one-by-one.
And it should really be done soon because distros already have interesting hacks to move these plugins to -good for empathy...
Adding dependency for the separate rtpmux moving ticket. Imho autoconvert, value could even go to core. We might need autoconvert in playbin2 for doing e.g.ac3 passthrough. For dtmf there is bug #607321. Regarding liveadder, it would be nice to check if the elemnt could be moved to the adder plugin to share code. I totally agree with having different bugs to discuss the needed improvements separately.
The reason I didn't file bugs is that I wanted to review them myself for all the smallish stuff before doing that. And also write unit tests for those that don't yet have them. And I've been lazy...
Also, liveadder should probably use GstCollectPads2 at some point (bug #532944) that were added into the new video mixer.
And ideally adder would support that itself, same as videomixer.
The liveadder functionality should be merged into adder, collectpads2 should make that a bit easier already.
Yes, also the flushing support for collectpads I'm currently working on will make this easier too (because thread decoupling of inputs and output)
I think we can close this. The audiomixer in -bad should support all of this now, and if not please file specific bugs with missing features against it instead.