After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584887 - Get rid of deprecated libgnome(ui)
Get rid of deprecated libgnome(ui)
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks: 602311
 
 
Reported: 2009-06-05 03:55 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-01-13 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replacing libgnome(ui) with EggSMClient and plain Glib/GTK+ (122.05 KB, patch)
2009-11-03 23:57 UTC, Florian Müllner
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-06-05 03:55:01 UTC
See http://live.gnome.org/LibgnomeMustDie

$ git grep "libgnome"

configure.ac:             libgnome-2.0 >= $LIBGNOME_REQUIRED \
src/fe-gnome/gui.h:#include <libgnome/gnome-program.h>
Comment 1 Javier Jardón (IRC: jjardon) 2009-06-05 03:56:28 UTC
$ git grep "libgnomeui"

configure.ac:                  libgnomeui-2.0 >= $LIBGNOMEUI_REQUIRED \
src/fe-gnome/fe-gnome.c:#include <libgnomeui/libgnomeui.h>
Comment 2 Ritesh Khadgaray ( irc:ritz) 2009-09-11 19:44:39 UTC
__self:

src/fe-gnome/fe-gnome.c:101:    gui.program = gnome_program_init ( ...
src/fe-gnome/util.c:142: path = gnome_program_locate_file (...

reference:

ToDo
* GnomeProgram 
  - easier GOptionContext integration than the current plain gtk interfaces 
* gnome-util
  - gnome_program_locate_file wrappers
Comment 3 Florian Müllner 2009-11-03 23:57:39 UTC
Created attachment 146887 [details] [review]
Replacing libgnome(ui) with EggSMClient and plain Glib/GTK+

A first shot at dropping libgnome(ui) dependency. The patch is huge, but mostly cut-and-paste code from libegg to replace GnomeClient (new subdirectory src/libeggsmclient).
I removed the save_session callback from src/fe-gnome/fe-gnome.c, as it didn't do anything apart from setting the restart command, which should be covered by the call to egg_set_desktop_file().
The only call I did not find a suitable replacement for is gnome_accelerators_sync() in src/fe-gnome/fe-gnome.c - in the patch, it is removed without any replacement, which is what various gnome modules I investigated did. I hope that's OK.
Comment 4 André Klapper 2009-12-20 14:24:16 UTC
Can the last patch please get a review?
Comment 5 Ritesh Khadgaray ( irc:ritz) 2010-01-13 10:37:49 UTC
Review of attachment 146887 [details] [review]:

> gnome_accelerators_sync() in src/fe-gnome/fe-gnome.c
Epiphany seem to be using one. Will push this in. 

http://git.gnome.org/browse/epiphany/commit/?id=659169914fa8da235b35730c688a23c3caca8b3a

__self: 
http://live.gnome.org/SessionManagement/EggSMClient

Looks good. Committing.