After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 584263 - When I compose or reply a message with Thunderbird, the Ctrl+End key combination is not work.
When I compose or reply a message with Thunderbird, the Ctrl+End key combinat...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.26.x
Other All
: Normal normal
: 2.28.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404409
 
 
Reported: 2009-05-30 08:41 UTC by Hammer Attila
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
This is a debug.out, demonstrate my problem. (190.13 KB, text/plain)
2009-06-01 07:39 UTC, Hammer Attila
  Details
proposed patch (1.71 KB, patch)
2009-07-09 23:35 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Hammer Attila 2009-05-30 08:41:42 UTC
Please describe the problem:
Dear Developers!

I using Thunderbird 3.0B2 and Orca 2.26.2 release. All structural navigation commands configured correctly my system. When I compose a new e-mail or reply an e-mail, if I press Ctrl+End key combination the caret does'nt jump the end of the letter, the caret shows the actual line. If I read an e-mail, this key combination works perfect.


Steps to reproduce:
1. If not defined, define the needed structural navigation keys.
2. Launch Thunderbird, and try compose a new message or reply any message, and write any text.
3. Press Ctrl+home to jump beginning of the message, and try press Ctrl+End key combination. Orca does'nt speak the last line of the message and caret not moved to the last line.


Actual results:
If I press Ctrl+End key combination, Orca does'nt speak the last line of the message and caret not moved to the last line

Expected results:
Please if I press Ctrl+End key combination, the caret change the last line and Orca speak the last line, similar when read an e-mail because when you do this task, this key combination work right.

Does this happen every time?
Yes.

Other information:
Comment 1 Hammer Attila 2009-05-30 09:04:21 UTC
Oh, I found another problem. When I write a message body and press Shift+Tab key, impossible navigate the subject edit box with arrow keys, home and end key, Backspace key does'nt say the deleted character. Orca does'nt speak the subject line characters or whole subject line.
When I press two Shift+tab key and one tab key, any navigation keys works correct the subject line and easy edit the subject line.
Comment 2 Hammer Attila 2009-06-01 07:39:33 UTC
Created attachment 135706 [details]
This is a debug.out, demonstrate my problem.

I send a debug.out file, this is demonstrate what the problem (I hope). :-):-)
I reply an e- mail and write two line:
"Apple
Potato"
After this, I jump beginning the letter with Ctrl+home and try to jump end of the letter with Ctrl+End key. When I try this task, I  see following traceback error with debug.out file:
Traceback (most recent call last):
  • File "/var/lib/python-support/python2.6/orca/input_event.py", line 187 in processInputEvent
    consumed = self.function(script, inputEvent)
  • File "/var/lib/python-support/python2.6/orca/scripts/toolkits/Gecko/script.py", line 5987 in goBottomOfFile
    [obj, characterOffset] = self.getBottomOfFile()
  • File "/var/lib/python-support/python2.6/orca/scripts/toolkits/Gecko/script.py", line 3641 in getBottomOfFile
    obj = self.getLastObject(documentFrame)
  • File "/var/lib/python-support/python2.6/orca/scripts/toolkits/Gecko/script.py", line 3667 in getLastObject
    lastChild = documentFrame[documentFrame.childCount - 1]
  • File "/usr/lib/python2.6/dist-packages/pyatspi/accessible.py", line 468 in __getitem__
    raise IndexError IndexError

I see this problem with Orca 2.26.2 and 2.27.2 pre versions. I try to delete my Orca settings and reconfiguring all settings, but does'nt solve my problem. :-(:-(
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-07-09 23:27:00 UTC
(In reply to comment #1)
> Oh, I found another problem. When I write a message body and press Shift+Tab
> key, impossible navigate the subject edit box with arrow keys, home and end
> key, Backspace key does'nt say the deleted character. Orca does'nt speak the
> subject line characters or whole subject line.
> When I press two Shift+tab key and one tab key, any navigation keys works
> correct the subject line and easy edit the subject line.
> 

Because we like to have just one bug per bug report, I've opened bug 588204 for this issue.
Comment 4 Joanmarie Diggs (IRC: joanie) 2009-07-09 23:35:13 UTC
Created attachment 138160 [details] [review]
proposed patch

This solves the problem for me. It boils down to some sanity checking. However, because it's in the Gecko script, I should run the regression tests just to be safe. I'll do that tonight.
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-07-10 02:42:12 UTC
As expected, all regression tests passed. Will please review. Thanks!
Comment 6 Hammer Attila 2009-07-10 05:33:03 UTC
Joanmarie, thang you your patch.
The Ctrl+End key combination works again when Orca is running.
When I write or reply a message, now all works fine. I tested the patch with Orca development version (2.27.4pre).
I have one question:
Coming out any time maintained 2.26.4 Orca release, similar with 2.24.4 release? I known, 2.26.3 maintained release comed out with June 29.
I ask this, because this fix is important with actual stable release.

Attila
Comment 7 Willie Walker 2009-07-10 11:03:16 UTC
(In reply to comment #6)
> Coming out any time maintained 2.26.4 Orca release, similar with 2.24.4
> release? I known, 2.26.3 maintained release comed out with June 29.

The release cycle for GNOME 2.24 and GNOME 2.26 has ended.
Comment 8 Willie Walker 2009-07-10 11:04:50 UTC
(In reply to comment #5)
> As expected, all regression tests passed. Will please review. Thanks!

Looks safe and as you say -- it's sanity checking.  Many thanks!  Please commit to master.
Comment 9 Joanmarie Diggs (IRC: joanie) 2009-07-10 14:26:48 UTC
Thanks Will. Done. Closing as FIXED.