GNOME Bugzilla – Bug 583115
make location of status icons more predictable
Last modified: 2010-03-28 14:11:35 UTC
Currently the layout order of status icons is not predictable. It would be better if it was. Owen suggested sorting by WM_NAME or some other property may be a simple and effective solution.
Created attachment 135776 [details] [review] patch to use WM_CLASS Actually Owen recommended using the res_class member of the WM_CLASS struct. This patch uses this. Maybe we can come up with a better order but this at least is much better than the first come first served order we have today.
Also this property should be set correctly even for tray icon windows according to: http://standards.freedesktop.org/systemtray-spec/systemtray-spec-latest.html#id2509999
Couple of comments: - is it really useful to transform the latin1 string to utf8 when you're going to use a non-utf-8 aware function to do the comparison? - is the res_class supposed to change at run-time? If not, couldn't we tag the widgets with g_object_set_data(...) and use g_slist_find_custom() to find the position?
After installing Fedora 11 and finding the volume applet had moved to an weird location and the ability to move it was broken, I filed a bug with the RedHat bugzilla explaining why the new volume control location was inconvenient, unexpected, and possible dangerous for laptop users: https://bugzilla.redhat.com/show_bug.cgi?id=506850 The bug was immediately closed as a duplicate of another bug in the RedHat bugzilla database about the inability to position the volume control applet independently of notification area: https://bugzilla.redhat.com/show_bug.cgi?id=505711 That bug was then closed as an "upstream" bug and references this GNOME bug. I can't say that I see this bug as identical to my original issue, as it doesn't mention the volume control at all. But I do grok the need to make the volume control appear in the predictable location and I think the location should be where it has traditionally been in the far upper right corner. On a desktop box the exact location of the volume control may not be a big problem but on a laptop it's more of an issue. Please see my comments on the first Redhat bug linked above for more detail.
I think you may need to wait for plug-added on the socket to be sure the window is ready.
Colin has a better approach here: http://live.gnome.org/Features/StandardIconOrdering With transient icons appearing at the left side.
Created attachment 145576 [details] [review] use standard order Here is a patch that uses the order defined in http://live.gnome.org/Features/StandardIconOrdering It is a straight port of Colin's shell patch from bug 598313
Created attachment 145870 [details] [review] add network role for Mandriva net_applet please apply this patch if previous patch is committed
What about gnome-shell? is there a different approach, or does it use the same code?
Certainly related to https://bugzilla.gnome.org/show_bug.cgi?id=531282
bug 610319 has a patch that sets wmclass on the new keyboard status icon in gnome-settings-daemon.
Created attachment 154095 [details] [review] updated patch Here is an updated patch that handles the keyboard icon too.
Thanks, committed! Fred: can we chat tomorrow about the mandriva patch? Just ping me :-)