GNOME Bugzilla – Bug 582783
Get rid of deprecated libgnome(ui)
Last modified: 2009-07-26 12:13:42 UTC
GNOME 3 will not ship libgnome/ui anymore. See http://live.gnome.org/LibgnomeMustDie . For the status of your module see the automatic statistics at http://www.gnome.org/~fpeters/299.html (updated every two hours). $:andre\> cd gnome-system-tools/ $:andre\> grep -r libgnome . ./src/common/gst-tool.c: #include <libgnomeui/libgnomeui.h> ./src/common/gst-tool.c: #include <libgnome/gnome-program.h> ./src/common/gst-tool.c: #include <libgnome/gnome-help.h> ./src/boot/boot-druid.h: #include <libgnomeui/gnome-druid.h> ./gnome-system-tools.spec.in: %define libgnomeui_version 2.0.0 ./gnome-system-tools.spec.in: Requires: libgnomeui >= %{libgnomeui_version}
Created attachment 138674 [details] [review] Remove unneeded include headers Grmpf. Bugzilla ate my long comment here. So a new short version: * I removed the three headers from gst-tool.c as they are not needed: * gnome-program: There are no calls to gnome_program whatsoever. * gnome-help: There is one line command = g_strconcat ("gnome-help ghelp://", uri, "?", section, NULL); but that does NOT mean that it still uses gnome-help: <kmaraas> no, it just launches gnome-help aka yelp * libgnomeui: Generic headers suck. And this one seems to be not needed. * I grepped liboobs (that g-s-t drags in) for "include <libgnome" and "include <gnome". No matches. That leaves "only" GnomeDruid to fix.
Sorry Andre, but I'm not sure I'll have time to look at that in time. But you're able to commit it without me... ;-) Just a remark: #ifdef ENABLE_GNOME -#include <libgnomeui/libgnomeui.h> -#include <libgnome/gnome-program.h> -#include <libgnome/gnome-help.h> #else #include <stdlib.h> #endif I guess you can remove all those #ifdefs and just use "#include <stdlib.h>", that wouldn't hurt... About GnomeDruid, that would be more complex, but maybe the modules using it can be completely deprecated, which Andy Owen seem to be willing to do.
Thanks for the quick comment. Committed with the changes described in comment 2: http://git.gnome.org/cgit/gnome-system-tools/commit/?id=14b59e60e245ae3efb6505bbc66fc682b9eb20dd Now only GnomeDruid left (bug 571234).
So with bug 571234 fixed, we can close that one too. I've updated the dependencies in the .spec.in package file in case they are used by somebody. See 1a740a5aa30cfc4a63233e8b6649c32305b2fbe5. So that one is done! Thanks for you work.
Thanks everybody!