GNOME Bugzilla – Bug 571234
Migrate from GnomeDruid to GtkAssistent
Last modified: 2009-07-25 22:51:50 UTC
See http://www.mail-archive.com/evolution-hackers@gnome.org/msg01635.html http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkAssistant.html http://live.gnome.org/LibgnomeMustDie ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_buttons_sensitive (druid->druid, TRUE, enabled, TRUE, FALSE); ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_page (druid, next_page); ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_buttons_sensitive (druid->druid, TRUE, enabled, TRUE, FALSE); ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_page (druid, next_page); ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_buttons_sensitive (druid->druid, TRUE, enabled, TRUE, FALSE); ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_page (druid, next_page); ./gnome-system-tools/src/boot/boot-druid.c: gnome_druid_set_page (druid, next_page);
*** Bug 463239 has been marked as a duplicate of this bug. ***
Is the "boot" module ever even built? How?
*shrug*. And I don't expect many answers here, as g-s-t is currently unmaintained. Maybe another option is to simply drop that part of the code if it's really unused.
Simon: (In reply to comment #2) > Is the "boot" module ever even built? How? According to bug 572355 comment 14: "The code in /src/boot is unused and not even built."
Indeed in the following commit, the boot and disk tool were removed: http://git.gnome.org/cgit/gnome-system-tools/commit/?id=5660bf86ed2f650f7606be0c3a31f9f9d5fdcd75
Well, the code was not removed from the repo. It's just that the build options for them were removed. Now who is brave enough (and maintainer) to remove the files from the git repository? People interested in it can still use an older revision...
Yes, I was just indicating there is not even a configuration option to build them. From http://bugzilla.gnome.org/show_bug.cgi?id=582783#c2, it seems Andy might be brave enough :p Anyway it has always been marked experimental and Ubuntu & Debian, the only major users of g-s-t these days do not ship it since a long time. I can make a quick patch if somebody is really interested and wants to close this quickly. Well we could close this one and #582783 anyway since this one is a false positive. Carlos: your b.g.o. address seems wrong (or you have some redirection from imendio maybe). Could you update it? Do you know any distro using the boot tool and do you think it's worth porting it?
Please post patch if you can, I'll commit it. Removing not used code is not a problem to me... Thanks!
Ok, I added the flags to build, but on top of that: - there is not even any tiny support in liboobs/system-tools-backend - it does not compile because of gnome-druid but glade too I was starting to retrieve the glade file from history and all, but since it will be removed afterwards and will still not work without the backend... Forget it, just trash the boot/ directory and that's all. We close both bugs, thanks.
So, can someone go ahead and remove the code from git, please? Highly welcome.
Created attachment 139210 [details] [review] Kill the boot tool Ho, I thought Milan would directly remove the directories. If you really need a patch, here it is.
Thanks! I could remove the directories, but I would have missed the .spec.in file, so your patch was useful. Another goal reached for the release! Please go on providing patches, I'll look after them... Pushed as de6a626edcc34664480f1ffe7a363c4c6eed3f19.