GNOME Bugzilla – Bug 581621
Update vendor list in display-name.c
Last modified: 2009-07-28 19:57:00 UTC
Ajax tells me that the vendor list in display-name.c is kind of outdated. There is a much more complete version here: http://git.fedorahosted.org/git/?p=hwdata.git;a=blob_plain;f=pnp.ids;hb=HEAD (In an ideal case, we would just share that file, but it seems to be a Red Hat-ism currently...)
Created attachment 134126 [details] [review] read the file Here is the patch I'm going to put into F11. Might make sense to do something like this and make the location of the file configurable...
What about: + add a configure flag to specify a location of such a file; + hack autogen.sh to wget the file from git so that on distcheck, the file ends in the tarball; + only install the file during "make install" if the configure flag wasn't used This way, distros not using hwdata can easily benefit from the data there. And distros using will still use it, without any change (no new file in gnome-desktop). Alternatively, can't we make this file part of some xorg package? :-)
Hrm, there are some differences in the lists. I just checked 4 lines and: + AIC is "AG Neovo" for gnome-desktop and "Arnos Insturments & Computer Systems" for hwdata (type in Instruments, btw) + DEL is "Dell" for gnome-desktop and "Deltec Corporation" for hwdata + ABP doesn't exist in hwdata (the 4th line was ACR and it was the same) So, hrm, who's right? :-)
*** Bug 579024 has been marked as a duplicate of this bug. ***
pnp.ids was generated from Microsoft's registry of same. Even that contained several duplicates, so it's clearly not perfect. I suspect the dominant use for it is going to be monitor IDs, so I'm entirely willing to call DEL Dell and not Deltec. I could easily make a git module for it in Xorg too. hwdata is really just the metamodule we use in fedora for pci.ids and friends, so pulling pnp.ids from somewhere else is completely par for the course.
(In reply to comment #5) > I could easily make a git module for it in Xorg too. hwdata is really just the > metamodule we use in fedora for pci.ids and friends, so pulling pnp.ids from > somewhere else is completely par for the course. Up to you, if you think it's a good idea. I've implemented what I suggested in comment #2 to make use of all this right now: there's a --with-pnp-ids-path configure option now. I'm a bit worried that we keep the hash table in memory all the time -- it's probably around 50kB since that's the size of the file. So gnome-settings-daemon will be a bit larger. I've opened bug 590059 for this.