After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577979 - Pressing Down Arrow from the middle of a multi-line HTML list item initially moves to the beginning of the line when arrowToLineBeginning is False
Pressing Down Arrow from the middle of a multi-line HTML list item initially ...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.26.x
Other All
: Normal minor
: 2.26.1
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403 404409
 
 
Reported: 2009-04-05 02:49 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-04-12 21:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
fix (9.81 KB, patch)
2009-04-12 21:43 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-04-05 02:49:03 UTC
This is a spin-off bug from Bug 577239 (Cannot navigate by line through multi-line HTML list items in Firefox/Thunderbird when arrowToLineBeginning is False.)

Steps to reproduce:

1. Load this test case: http://bugzilla.gnome.org/attachment.cgi?id=131648&action=view

2. Set arrowToLineBeginning to False

3. Position the caret towards the middle of the first line of one of the multi-line list items.

4. Press Down Arrow

Expected results: The caret would move to the second line of that list item

Actual results: The caret moves to the beginning of the first line of that list item.

Note that from here, pressing Down Arrow again moves to the second line of the list item as expected. In other words, Orca isn't getting stuck/preventing navigation within the list. It's merely taking an unwanted detour to the start of the list first. As such, I've marked the severity as "minor." Still I'd like to get this resolved for 2.26.1 as it is an annoyance.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-04-12 21:43:45 UTC
Created attachment 132572 [details] [review]
fix

This turned out to be an easy, two-line fix which is isolated to the code which is excecuted only when arrowToLineBeginning is set to False by the user.

This patch fixes the problem, pylints to a 10.0, and passes the one regression test we currently have related to arrowToLineBeginning being set to False. This patch also includes a new regression test for this bug.

This passes the low risk test. And while it's not what I would call "high impact," this bug is an annoyance for users who prefer arrowToLineBeginning set to False. Therefore, I've gone ahead and committed this patch both to trunk and to the gnome-2-26 branch.