GNOME Bugzilla – Bug 577239
Cannot navigate by line through multi-line HTML list items in Firefox/Thunderbird when arrowToLineBeginning is False
Last modified: 2009-04-05 03:00:54 UTC
Please describe the problem: If you are navigating by line through an html page and encounter a list item that spans multiple lines, Orca becomes stuck on the first line of the list item. If you navigate to the end of the first line and navigate using the right arrow key onto the second line, pressing the down arrow will move Orca's focus back to the first line, and the first line of the list item will be repeated. Steps to reproduce: 1. Start Orca. 2. Start Firefox. 3. Open an HTML page which contains list items spanning multiple lines (example will be attached). 4. Navigate through the page using the down arrow and attempt to read the entire contents of a list item that spans multiple lines. 5. Once the first line of the list item is read repeatedly,press the end key, press the right-arrow key twice to get onto the next line, then press the down arrow key. Actual results: When you reach the list item that spans multiple lines, the first line of that list item is repeated each time the down arrow is pressed. Expected results: Each line of the list item would be read in order as focus moved across them. Does this happen every time? yes. Other information: Read-all successfully reads all lines of a multi-line list item.
Thanks David! Which version of Orca are you using, which version of FF and Thunderbird are you using, which version of GNOME are you on, and which OS distribution and version are you using?
Created attachment 131648 [details] Example HTML page A simple web page containing an ordered list and an unordered list.
Created attachment 131649 [details] Debug log in Firefox Debug log showing Orca's behavior when reading list items spanning multiple lines.
I tried reproducing this on OpenSolaris 20081.11 b110 (GNOME 2.24.2) with Firefox 3.1 Beta 2 and Orca from trunk. It seems to read the lines from the attached HTML page just fine and doesn't get stuck. :-(
I've seen this using versions of Orca from 2.24.0 through svn trunk today (2.27.1pre, revision 4655). Ubuntu Intrepid using gnome 2.24.x Firefox 3.6a1pre Thunderbird v3.0b3pre As I said in an email message last week, I've seen this for a long time. I'll attach a tb email message and log as well.
Created attachment 131651 [details] Thunderbird email attachment Email message from Thunderbird which contains an ordered list that also doesn't allow line by line navigation of a multi-line list item
Created attachment 131652 [details] debug log in Thunderbird Shows repeating of first line of list item that spans multiple lines. Also, I pressed the end key, the right arrow a few times and then the down arrow again.
I just tested the html page attached above in Firefox 3.0.8 and 3.1b4pre with the same behavior. Let me know if you would like to see debug logs. Thanks.
I'll add this one to my 2.26.1 list. Unless you want it Will. :-)
I can confirm this bug as described if I turn off Orca's setting to always position the cursor at the start of the line. Changing status to confirmed. We'll get this fixed for 2.26.1. Thanks for the report David!
Created attachment 131889 [details] [review] revision 1 This patch solves the reported problem -- at least for the Firefox test case. At the moment I do not have an installed t-bird trunk. It's pylinted. Because the change is isolated to blocks of code which do NOT get executed unless the user has opted to disable Orca's setting to position the text at the beginning of the line, and because we have no regression tests that are run with that setting disabled, running the regression tests will not tell us anything IMHO. Therefore: 1. David, please beat on this patch for a few days in both Firefox and Thunderbird. 2. I'll write a few regression tests which will include this scenario and the disabling of the setting in question. While manually testing, I did notice that if one arrows to the middle of the first line of a list item which spans multiple lines, the initial press of Down Arrow causes the caret to be positioned at the beginning of the line first. I've not debugged that yet. I will. But that might be a fix that needs to take place elsewhere (and hence be better tested), so I'll address that issue separately. This patch at least addresses the reported problem and does so in an isolated fashion.
The patch looks nice and isolated and I say check it in if it solves the problem David is experiencing. Thanks Joanie!
Works fine with thunderbird too.
Joanie, this patch is working very well. I've tested it on 5 web pages and 3 email messages and Orca is reading all of the multi-line list items perfectly. Thanks!
Patch, along with David's test case (thanks David!) and a regression test, committed to both trunk and the gnome-2-26 branch. I've opened bug 577979 for the issue I point out at the end of my comment #11.