After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575911 - Add 'Rule of fifths' crop guide overlay
Add 'Rule of fifths' crop guide overlay
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal enhancement
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2009-03-19 04:22 UTC by Nelson A. de Oliveira
Modified: 2010-06-24 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for rule of fifths guideline (4.76 KB, patch)
2009-11-16 23:02 UTC, Nelson A. de Oliveira
needs-work Details | Review
Patch for rule of fifths (4.31 KB, patch)
2010-06-24 01:24 UTC, Nelson A. de Oliveira
committed Details | Review

Description Nelson A. de Oliveira 2009-03-19 04:22:57 UTC
Hi!

While GIMP already have the options "center lines", "rule of thirds", and "golden sections" for guidelines (when using the selection tools), it would be nice if it could also has the diagonal method (see http://www.diagonalmethod.info/ for more info), a grid overlay, triangle and also the golden spiral (see http://pendery.org/photography/october-2007/lightroom-11-12-crop-overlay-aid-composition.htm for all of them).

Thank you very much!
Comment 1 Martin Nordholts 2009-03-19 06:22:35 UTC
Hi! That was recently added.

*** This bug has been marked as a duplicate of 566443 ***
Comment 2 Martin Nordholts 2009-03-19 06:24:18 UTC
Oh sorry you were requesting more methods than the diagonal one.
Comment 3 Sven Neumann 2009-03-19 20:35:58 UTC
Please provide a patch then.
Comment 4 Nelson A. de Oliveira 2009-11-16 23:02:46 UTC
Created attachment 147941 [details] [review]
Proposed patch for rule of fifths guideline
Comment 5 Martin Nordholts 2010-06-23 04:59:58 UTC
Review of attachment 147941 [details] [review]:

Um, the patch doesn't even compile.
Comment 6 Nelson A. de Oliveira 2010-06-24 01:24:34 UTC
Created attachment 164463 [details] [review]
Patch for rule of fifths

Updated patch.
Applies and compiles fine now.
Comment 7 Martin Nordholts 2010-06-24 06:31:42 UTC
Thanks!

commit c4588f1209b840dd7f9138fedf9a6f130beccc2e
Author: Nelson A. de Oliveira <naoliv@debian.org>
Date:   Wed Jun 23 22:21:57 2010 -0300

    Bug 575911 - Add 'Rule of fifths' crop guide overlay
    
    Implement a rule of fifths guideline for GIMP. See
    http://markhancock.blogspot.com/2006/03/address-basic-composition.html
    for more info.
Comment 8 Martin Nordholts 2010-06-24 06:31:59 UTC
Review of attachment 164463 [details] [review]:

Committed.