After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566443 - diagonal method guidelines for crop tool
diagonal method guidelines for crop tool
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.6.0
Other All
: Normal enhancement
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2009-01-03 20:28 UTC by Simon Oosthoek
Modified: 2009-03-19 06:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implements a diagonal lines method in Gimp. Patch against rev. 28154 (4.03 KB, patch)
2009-03-13 19:03 UTC, Lukasz Hladowski 		committed Details | Review

Description Simon Oosthoek 2009-01-03 20:28:23 UTC 
I'd like to (re-)request diagonal guidelines for at least the cropping tool to assist in selecting according to the diagonal method concept as described here:
http://www.diagonalmethod.info/

Apparently this has been requested/implemented earlier for the Gimp, but it wasn't accepted into trunk for some reason:
http://www.mail-archive.com/gimp-developer@lists.xcf.berkeley.edu/msg14463.html

It seems the feature is currently implemented in Photoshop/lightroom (apparently without informing the author(s) of the original article, I suppose it would be nice to send them an e-mail if it is implemented in the Gimp)

Thanks in advance,

Simon
Comment 1 Martin Nordholts 2009-01-03 20:35:01 UTC 
Hi

As far as I can see the reason that discussion died out was because no one wrote a working patch. I think we can keep this bug report open so that the one who writes the patch can attach it here.
Comment 2 Sven Neumann 2009-01-06 22:17:17 UTC 
The mail linked above has a patch. Probably needs to be updated to apply cleanly...
Comment 3 Lukasz Hladowski 2009-03-13 19:03:02 UTC 
Created attachment 130596 [details] [review]
Implements a diagonal lines method in Gimp. Patch against rev. 28154

This patch is based on the work of Tim Jedlicka. It corrects the bug that shows up when user has made a perfectly square selection - the previous one drew over the old guidelines removing them.
Comment 4 Lukasz Hladowski 2009-03-13 19:08:38 UTC 
Could I kindly ask that if this patch is included the name of the inventor of this method, Edwin Westhoff, is mentioned?
Comment 5 Sven Neumann 2009-03-13 22:06:28 UTC 
You mention it in your patch, that should be sufficient. Why do you mention that the method has been registered? That comment should be removed, IMO.
Comment 6 Sven Neumann 2009-03-14 13:00:25 UTC 
Thanks for your contribution.

2009-03-14  Sven Neumann  <sven@gimp.org>

	Bug 566443 – diagonal method guidelines for crop tool

	* app/tools/tools-enums.[ch]
	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw_guides):
	applied a slightly modified patch from Lukasz Hladowski, based on
	a patch from Tim Jedlicka. This adds diagonal guidelines as
	described by Edwin Westhoff to the rectangle tools.
Comment 7 Martin Nordholts 2009-03-19 06:22:35 UTC 
*** Bug 575911 has been marked as a duplicate of this bug. ***