After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572489 - atk_text_get_range_extents should use g_return_if_fail
atk_text_get_range_extents should use g_return_if_fail
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
git master
Other All
: Normal minor
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-02-19 20:55 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2013-12-10 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (418 bytes, patch)
2009-02-20 04:13 UTC, yue.wang 		none Details | Review
new patch , missing ';' (419 bytes, patch)
2009-03-26 03:32 UTC, yue.wang 		committed Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2009-02-19 20:55:38 UTC 
Please describe the problem:
Notice that in http://svn.gnome.org/viewvc/atk/trunk/atk/atktext.c?view=markup function atk_text_get_range_extents should use g_return_if_fail instead of just return, in this line:

if (start_offset < 0 || start_offset >= end_offset)
  return; 

Besides, zeroing the Atk.TextRectangle in this case would be also friendlier for bindings.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 yue.wang 2009-02-20 04:13:34 UTC 
Created attachment 129119 [details] [review]
patch
Comment 2 yue.wang 2009-03-26 03:32:36 UTC 
Created attachment 131396 [details] [review]
new patch , missing ';'
Comment 3 André Klapper 2011-06-23 22:06:23 UTC 
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 .
PLEASE NOTE:
If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla.
Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-12-10 17:03:00 UTC 
Review of attachment 131396 [details] [review]:

Just committed adding a commit message. Thanks for the patch. Closing bug.