After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 571593 - Add a configuration option to force new windows to be opened in tabs
Add a configuration option to force new windows to be opened in tabs
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 337725 608211 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-02-13 08:15 UTC by Alejandro G. Castro
Modified: 2010-11-10 23:56 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Patch adding this feature (2.46 KB, patch)
2009-02-13 08:17 UTC, Alejandro G. Castro 		none Details | Review
New patch with a style typo fixed (2.46 KB, patch)
2009-02-13 08:20 UTC, Alejandro G. Castro 		none Details | Review
Fixed a couple of errors (2.44 KB, patch)
2009-02-13 08:51 UTC, Alejandro G. Castro 		none Details | Review

Description Alejandro G. Castro 2009-02-13 08:15:45 UTC 
When a webpage requests open a new window we can add a gconf option to force the new window to be opened in a tab, instead of creating an epiphany new window.
Comment 1 Alejandro G. Castro 2009-02-13 08:17:32 UTC 
Created attachment 128624 [details] [review]
Patch adding this feature

This patch adds a gconf key that forces the new windows to be opened in tabs instead of creating an Epiphany window.
Comment 2 Alejandro G. Castro 2009-02-13 08:20:15 UTC 
Created attachment 128625 [details] [review]
New patch with a style typo fixed
Comment 3 Alejandro G. Castro 2009-02-13 08:51:05 UTC 
Created attachment 128627 [details] [review]
Fixed a couple of errors

Thanks Xan for the review ;)
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2009-02-15 10:23:12 UTC 
*** Bug 337725 has been marked as a duplicate of this bug. ***
Comment 5 Xan Lopez 2009-02-15 22:20:45 UTC 
Thanks for the patch! Committed to trunk.
Comment 6 Wouter Bolsterlee (uws) 2009-02-15 22:40:03 UTC 
Great! Is there any chance of this being backported to the gnome-2-26 branch?
Comment 7 Christian Persch 2009-02-15 23:00:52 UTC 
No, this doesn't work correctly in all cases with gecko.
Comment 8 Reinout van Schouwen 2010-01-27 10:30:36 UTC 
*** Bug 608211 has been marked as a duplicate of this bug. ***
Comment 9 Nicolas Dufresne (ndufresne) 2010-11-10 23:56:11 UTC 
Just for people that comes across, this feature is nice but the implementation has some bugs with resized popup window. Follow this link if you want to test:

http://people.collabora.co.uk/~nicolas/public/test.html

The button should open a separate window since the size of it is set and is smaller then the screen, while the links should open new tabs. This policy is at least followed by Chromium and Firefox.

Should we reopen ? or maybe create a new bug ?