GNOME Bugzilla – Bug 571464
Various typos and string problems
Last modified: 2010-03-17 08:19:00 UTC
While updating my translation, I found these: #: ../gladeui/glade-editor-property.c:2717 Choose parentless %s(s) in this project #: ../gladeui/glade-editor-property.c:2720 Choose %s(s) in this project - These two need to use ngettext, see: http://live.gnome.org/TranslationProject/DevGuidelines/Plurals #. Defined here for pretty translator comments (bug in intl tools, for some reason #. * you can only comment about the line directly following, forcing you to write #. * ugly messy code with comments in line breaks inside function calls). #. #: ../gladeui/glade-project.c:1588 - Where are our pretty translator comments? :) This is not a real problem in a message, but it seems that somebody forgot something - at least, removing a rant. #: ../gladeui/glade-project.c:3755 Toolkit version(s) required: - This should be simply "versions", as we can't know what the user will select (or something like this) #: ../gladeui/glade-builtins.c:499 Enter a filename, relative or fullpath to load the image - full path #: ../plugins/gtk+/gtk+.xml.in.h:1 A filname, full or relative path to load an icon for this toolbutton - filename #: ../plugins/gtk+/glade-icon-sources.c:694 Enter a filename or a relative or full path for this source of '%s' (Glade will only ever load them inthe runtime from your project directory). - in the #: ../plugins/gtk+/glade-label-editor.c:357 Setting %s to set desired width in charachters - characters #: ../plugins/gtk+/glade-store-editor.c:224 Add remove and edit rows of data (you can optionally use CNTL-N to add new rows and the Delete key to remove the selected row) - CTRL-N
Created attachment 153610 [details] [review] Proper ngettext calls for the first two strings. I'm not sure if the phrasing "%s widget" is appropriate here - perhaps it should be something else, I couldn't figure it out better from the code.
Created attachment 153612 [details] [review] Remove unneeded version(s) phrasing This removes the unneeded plurals from the "Toolkit version(s) required:" string. Also adds quotes to the project name, see: https://bugzilla.gnome.org/show_bug.cgi?id=573640#c2
Created attachment 153614 [details] [review] kill the charachters typo
Created attachment 153615 [details] [review] kill the chose and filname typos, and change one gtk+ to all caps
The other typos (CNTL, fullpath, inthe) are already fixed, could someone review my patches?
Review of attachment 153614 [details] [review]: Thanks for the patch
Review of attachment 153610 [details] [review]: Hi, since we rarely to never use direct calls for ngettext, I would really love this patch to come with a comment. As there are alot of strings to get translated right in Glade, it could easily happen again, but it would really handy if there was a comment saying: /* ngettext: does such and such and tells the translator something about your conditional bla bla */
Review of attachment 153612 [details] [review]: Thanks for the corrections again.
Review of attachment 153615 [details] [review]: Thanks again for typo fixes.
Created attachment 153714 [details] [review] ngettext calls with comments to developers I guess this much comment is enough, however I'm no longer sure that this will work as expected. The number that is passed to ngettext, currently GLADE_IS_PARAM_SPEC_OBJECTS (eprop->klass->pspec), should contain the exact number of items, and this seems to be a boolean... so not good enough for ngettext. If it's not possible to obtain the exact number, then the original construct could be used, just without (s), like: "Choose %s widgets in this project".
You cannot get the exact number in this context, because the dialog is meant to choose either 1 or multiple objects who conform to a said type (the user can select 1 or more if the dialog accepts multiple selections). I think the unplural strings are ok: _("Choose a %s in this project") ... and _("Choose a parentless %s in this project") (note that "%s" is resolving to the translated type name as shown in the palette/property editor). For the plural strings maybe it would be clearer to write _("Choose one or more %ss in this project") ... and _("Choose one or more parentless %ss in this project") and that way drop the parenthesis around plural. NOTE: its already a little vague what is meant by "parentless" here, ultimately the dialog should probably be broken down to warn about the parentless limitation in another string.
(In reply to comment #11) > You cannot get the exact number in this context, because > the dialog is meant to choose either 1 or multiple objects who > conform to a said type (the user can select 1 or more if > the dialog accepts multiple selections). > Ok, then no ngettext here. > > For the plural strings maybe it would be clearer to write > _("Choose one or more %ss in this project") ... and > _("Choose one or more parentless %ss in this project") > > and that way drop the parenthesis around plural. > No way! There is no such thing as "%ss"! This does not work, not even for english, and for other languages... it's hopeless to translate. Forget it. See: http://live.gnome.org/TranslationProject/DevGuidelines/Plurals I think "Choose one or more" is not good enough either, because there is no difference between "choose a %s" (~ 1 item) and between 'choose 1 or more items" - the first is just a subset of this.
Review of attachment 153612 [details] [review]: pushed
Review of attachment 153614 [details] [review]: pushed
Review of attachment 153615 [details] [review]: pushed
Created attachment 153728 [details] [review] No-nonsense version of the strings, no ngettext either
(In reply to comment #12) [...] > No way! There is no such thing as "%ss"! This does not work, not even for > english, and for other languages... it's hopeless to translate. Forget it. > Ugh, ofcourse yeah. > See: > http://live.gnome.org/TranslationProject/DevGuidelines/Plurals > > I think "Choose one or more" is not good enough either, because there is no > difference between "choose a %s" (~ 1 item) and between 'choose 1 or more > items" - the first is just a subset of this. What do you think would look nicer and sound right to the user: - Choose Buttons in this project (untranslatable) - Choose Button objects in this project (now we are calling "Buttons" "Button objects" instead, a little ambiguous, but translatable) - Choose Button type objects in this project (probably less ambiguous than the former) I agree that "one or more" is also a bit ambiguous/redundant, and would still have to end with "Buttons" and not "Button objects" to sound right in english. So, I guess I'm prepared to live with "Choose Button objects" even though it looks like broken english to me, I guess it would at least be translatable. Note we should not use "widgets" instead of "objects", because non-widget objects can show up in that dialog (text buffers, tree modals etc). If you have better ideas let me know, otherwise I will be happy to roll with either "Choose %s objects" or "Choose %s type objects".
Review of attachment 153728 [details] [review]: Ok as I said in my previous comment (mid-air collision), I'll be fine with this, although I think its best to s/widgets/objects in that text for better accuracy.
Created attachment 153730 [details] [review] final version, with %s type objects I think the last one is the best choice, "%s type objects" sounds good.
Review of attachment 153730 [details] [review]: Great, thanks for your patience, please commit :)
Review of attachment 153730 [details] [review]: pushed
*** Bug 571884 has been marked as a duplicate of this bug. ***
*** Bug 571867 has been marked as a duplicate of this bug. ***
*** Bug 571861 has been marked as a duplicate of this bug. ***
*** Bug 593439 has been marked as a duplicate of this bug. ***