GNOME Bugzilla – Bug 569652
e_source_list_peek_group_by_name not safe for localized names
Last modified: 2009-05-05 13:11:07 UTC
As a follow up for bug #362754 and bug #539467, the e_source_list_peek_group_by_name doesn't work when the group is created in a different locale than user uses in time of its call. Thus I propose to deprecate it and extend ESourceList with new functions: ESourceGroup *e_source_list_peek_group_by_base_uri (ESourceList *, const char *base_uri); void e_source_list_remove_group_by_base_uri (ESourceList *, const char *base_uri); ESourceGroup *e_source_list_ensure_group (ESourceList *, const char *base_uri, const char *name); The last will ensure an existence of the group and changes its name as requested in parameters. Returned pointer will be that group, which will be supposed to be always unreffed. The above functions will simplify usage in plugins and all around. I expect patches for all evo-family here too.
Gnome target is meant for bugs severe enough to delay a release. Please use the Target Milestone instead.
ouch :)
Created attachment 127757 [details] [review] proposed eds patch for evolution-data-server; New API functions and deprecation of the peek_by_name. One thing, I'm not sure whether we are able to migrate in exchange-esource.c, if we can do that, somehow, then the find_account_group can be thrown away and will be used only e_source_list_peek_group_by_properties.
Created attachment 127758 [details] [review] proposed evo patch for evolution; There were no fixes required on eex and evo-mapi side.
Milan, seems fine to me. Push to trunk
Created commit 26a8ddc in eds master. Created commit 2403bbc in evo master. Dropped chunk of caldav in eds part, as that file had been removed from sources.
Reopening because exchange-contacts.c in the exchange-operations plugin is still using that function.
Created commit d107a58 in master. Eh, overlooked that one. Thanks for pointing it out.