GNOME Bugzilla – Bug 539467
duplicated string in contact list pane if *translation* of "Google" != "Google"
Last modified: 2009-01-29 11:28:00 UTC
(awesome description, i know. you owe me a beer.) after running evo in egyptian arabic i have an arabic string in the calendar list that never goes away. $:> LANG=ar_AE.utf8 $:> evolution go to calendar, quit $:> LANG= <something else> $:> evolution expected result: an UI in the locale i chose. outcome: see attached screenshot. cool bug, is it a feature i just don't get? :) $:> rpm -qa | grep evolution evolution-data-server-devel-2.22.2-1.fc9.i386 evolution-webcal-2.21.92-1.fc9.i386 evolution-2.22.2-2.fc9.i386 evolution-data-server-2.22.2-1.fc9.i386 evolution-data-server-doc-2.22.2-1.fc9.i386 evolution-help-2.22.2-2.fc9.i386
Created attachment 113167 [details] صورة عن النافذة صورة عن النافذة
Can you translate the Arabic item?
yes: "جوجل" means "Google".
(for political correctness: pardon my ignorance, ae are of course united arab emirates and not egypt. *cough* /me hides)
aha. interesting: $:> gconftool-2 -g /apps/evolution/calendar/sources [<?xml version="1.0"?> ...blah blah... <group uid="1193573636.5223.0@embrace" name="Google" base_uri="Google://" readonly="no"><source uid="1201055846.6672.70@embrace" name="Google Test" relative_uri="http://www.google.com/calendar/feeds/whatever@gmail.com/private/full" color_spec="#BECEDD"><properties><property name="alarm" value="true"/><property name="username" value="whatever@gmail.com"/><property name="protocol" value="google"/><property name="auth" value="1"/><property name="refresh" value="30"/><property name="auth-domain" value="google"/><property name="ssl" value="1"/><property name="offline_sync" value="1"/></properties></source></group> ,<?xml version="1.0"?> <group uid="1209482627.3135.0@embrace" name="Kontakte" base_uri="contacts://" readonly="no"><properties><property name="create_source" value="no"/></properties><source uid="1209482627.3135.1@embrace" name="Geburts- und Jahrestage" relative_uri="/" color_spec="#DDBECE"><properties><property name="alarm" value="true"/><property name="delete" value="no"/></properties></source></group> ,<?xml version="1.0"?> <group uid="1213892091.15446.0@localhost.localdomain" name="جوجل" base_uri="Google://" readonly="no"/> ]
Ah. OK. This happens for every locale where the string "Google" is NOT translated to "Google" in the .po file - try with arabic or korean for example. 1) start evo with LANG=cs_CZ.utf8, no problems. 2) start evo with LANG=ar_AE.utf8 or with LANG=ko_KR.utf8, an offending string (either "جوجل" or "구글") shows up like in the screenshot. 3) start evo with LANG=cs_CZ.utf8 again, the offending string remains. the string we talk about may be #: ../plugins/google-account-setup/google-source.c:71 #: ../plugins/google-account-setup/google-source.c:78 msgid "Google" I like my bugs, I do.
(PS: If you type "Google" into google, you *can* break the internet. So please noone try it.)
Possible dupe of bug #362754? Milan's got a patch for it, of course.
wh00t, milan... skvělý. reminds me to call the kidnappers again to make sure he's on the guadec plane. don't know if the patch will also fix this issue. my problem isn't that the strings remain in the language evolution was first started in, my problem is that i get an additional string/gconf entry that never goes away. *maybe* milan's patch also fixes this problem, can't test it as i don't have a 2.23 build and wait for my new machine (won't waste time to set up a build on this broken laptop). let's set a dep and check back later on.
Created attachment 127002 [details] [review] proposed evo patch for evolution; actually, the other bug doesn't fix this, because it didn't know of there plugins. But this patch, hmm, that's totally different story... (I was lazy to test it, bare with me, please.) :) By the way, as I'm replacing e_source_list_peek_group_by_name, there will be very useful e_source_list_peek_group_by_base_uri for sure. Let's try to not forget next release and make this nice again. I'm not sure whether it makes any sense to propose also e_source_list_ensure_group (source_list, base_uri, name); which should cover all the code in these and CalDAV plugin. What about obsoleting e_source_list_peek_group_by_name too? (maybe Matt will add yet-another evolution[cleanup] bug for me) ;)
Patch looks good. As discussed over irc, am fine with the cleanup. As we have crossed the api freeze, the cleanup can be taken in for 2.28.
Committed to trunk. Committed revision 37165. Committed to gnome-2-24. Committed revision 37166. Added bug #569652