After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568631 - Orca does not update the position for same-page links which reference objects by name/id in Firefox 3
Orca does not update the position for same-page links which reference objects...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.25.x
Other All
: Normal normal
: 2.24.4
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-01-21 23:59 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-01-22 22:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
revision 1 (7.42 KB, patch)
2009-01-22 06:36 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-01-21 23:59:33 UTC
This is a spin-off bug from bug #544771.

> Navigate to http://live.gnome.org/Orca
> Tab down to "Does Orca work with Skype?" and activate the link.
> The focus is moved, but we are not updating to reflect the new location.

The reason why is the links in this instance are referencing objects by id rather than by anchor.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-01-22 06:36:54 UTC
Created attachment 126973 [details] [review]
revision 1

Pylinted and regression tested. Will please review. Thanks!
Comment 2 Willie Walker 2009-01-22 17:16:24 UTC
Seems like a decent way to check for a same page link.  If one were to jump off the page onto another link with a fragment, such as going from this bug page to http://live.gnome.org/Orca#head-57a68c24cf7c113345e8389db746bfe158e464ba, does the desired thing happen with the patch?
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-01-22 22:25:10 UTC
(In reply to comment #2)
> Seems like a decent way to check for a same page link.  If one were to jump off
> the page onto another link with a fragment, such as going from this bug page to
> http://live.gnome.org/Orca#head-57a68c24cf7c113345e8389db746bfe158e464ba, does
> the desired thing happen with the patch?
> 
Good catch Will! Thanks!

It does not. :-( But the patch doesn't break it or in any way impact it: Turns out we weren't doing the right thing before either. ;-) 

The issue you raise seems to be a different case: When a page finishes loading, the Gecko script's onStateChanged makes decisions about where to place the caret and what to present. I opened bug 568768 for that issue.

I've committed the patch attached to this bug to both trunk and the gnome-2-24 branch. Now to muck with onStateChanged. :-)