GNOME Bugzilla – Bug 544771
Orca no longer moving the cursor on same page links
Last modified: 2009-03-10 00:05:24 UTC
From Garrett on the Orca list: ------ Hello all, I'm using orca svn revision 4059. I've found that orca no longer moves the cursor in firefox when activating a same page anchor link. Here are the steps to reproduce this bug. 1. Go to Wikipedia. 2. Access any article. 3. Try to activate a link to any section in the article from the table of contents. Expected result: Orca should place the cursor at the heading of the linked-to section. Actual result: nothing happens. ------
Created attachment 115275 [details] [review] revision 1 We indeed were not updating the caret position like we should be doing. This patch won't move you to the heading; it will move you to the anchor associated with the link (which comes just before the [edit] link which comes just before the heading). I have not yet regression tested this.
Regression tests indicate this change causes us to double-speak a few things. Another patch hopefully coming soon (this time I'll regression test first. :-) )
Created attachment 115293 [details] [review] revision 2 This version seems to fair better in terms of not introducing regressions while solving the original problem. Please test.
Thanks Joanie, this last patch is working nicely.
Thanks Jon. Patch committed to trunk. Moving to pending.
Something on the FF side of things has broken our fix for this bug. (Verified by going back to the revision where this fix was initially checked in, i.e. back when we knew it worked). *sigh* Looking at debug output, what's broken our fix is a caret-moved event which we were counting on having gone AWOL. Unfortunately, because I did not make a same-page-link regression test way back when like I should've done, I don't know in what revision of Firefox trunk things broke. *sighs again, slapping forehead for good measure.* As y'all may have noticed, I'm getting more "religious" about making regression tests for everything now. Tomorrow/this weekend I'll add one for same-page links along with trying to pin down where the breakage occurred. Re-opening rather than filing a new bug for now....
It broke beginning with the 17 Sept trunk build of Firefox. I opened this Mozilla bug for the issue: https://bugzilla.mozilla.org/show_bug.cgi?id=459152 Blocking this bug, but leaving the milestone. We did fix an Orca bug and we did fix it for 2.23.6. :-) Once the Firefox bug is fixed things should resume working.
My bug was marked as a dup of a newer bug. Now we're tracking this one: https://bugzilla.mozilla.org/show_bug.cgi?id=460417 Still blocked, but hopefully not for much longer.
The blocking bug was marked as fixed. When I tried earlier, the fix apparently hadn't been included in the downloadable trunk versions. I just tried again. We are once again getting the correct event and we're once again doing the right thing as a result. Therefore, I'm once again closing this as FIXED. Let's hope it sticks this time. ;-)
Sorry, it looks like this bug needs reopening (for some reason i cant reopen it) Using orca trunk, and both intrepid firefox and nightly firefox 3.2a1pre: navigate to http://live.gnome.org/Orca tab down to "does orca work with skype" and activate the link. The focus is moved, but we are not updating to reflect the new location. i went back as far as orca rev 4300, and the same behaviour is observed with both the firefoxes. :(
That is a different type of "same page link". It's to a heading with an id rather than an actual anchor. As such, going back to different revisions of Orca shouldn't make a difference. And this may actually be a different bug, but I'll take a look today or tomorrow. Thanks for pointing this out.
Sorry for the spam. For comparison, perform the steps in the opening report of this bug, namely: 1. Go to Wikipedia. 2. Access any article. 3. Try to activate a link to any section in the article from the table of contents. On Wikipedia, they use proper anchors which is what the patch for this bug addressed. Do note that on wikipedia, the anchor is on the line immediately above the heading so one lands on an empty line initially. But if you down arrow once, you should be in the content as expected. (I just verified with Orca trunk.) Regardless, like I said, I'll take a look in a bit to see what needs doing for ids. Thanks again!
Marking this for 2.24.4, so keep in mind that work done in trunk should also be checked into gnome-2-24. Thanks!
I opened a new bug for the issue raised by Jon. Orca continues to move the cursor when navigating by same page links which point to anchors (e.g. wikipedia). Bug 568631 will track the new issue. It's targeted for 2.24.4. Re-targetting this one back to the fix release and re-closing as FIXED.