After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 568467 - aria-describedby text spoken twice via Where Am I
aria-describedby text spoken twice via Where Am I
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other opensolaris
: Normal normal
: 2.24.4
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-01-20 18:50 UTC by Willie Walker
Modified: 2009-01-21 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix the problem (5.77 KB, patch)
2009-01-20 19:22 UTC, Willie Walker
none Details | Review
Updated patch to resolve the problem and add a new regression test (6.57 KB, patch)
2009-01-21 21:27 UTC, Willie Walker
committed Details | Review

Description Willie Walker 2009-01-20 18:50:37 UTC
1) Go to http://codetalks.org/source/widgets/button/button.html.
2) Tab to the "Check Now" button.
3) Press KP_Enter to invoke Orca's Where Am I.

You will hear "Check to see if your order has been shipped." spoken twice.

The problem is that the "Check to see if your order has been shipped." text is also flagged as a 'aria-describedby' relation for the "Check Now" button.  As a result of this, the "Check Now" button has an accessible description and a DESCRIBED_BY relation, both of which end up being identical.
Comment 1 Willie Walker 2009-01-20 19:22:08 UTC
Created attachment 126859 [details] [review]
Patch to fix the problem

This patch seems to do the trick, and includes a new test.  It pylints to a 10.0.  I'm going to run the full FF test suite to see what it uncovers -- I suspect there are a number of tests with duplicate descriptions.
Comment 2 Willie Walker 2009-01-21 15:48:47 UTC
Further exploration of this may lead to another bug where we don't look at things with DESCRIBED_BY relations in all cases.  We might need to consider adding the text of the things doing the describing if the text is visible on the screen and also also really just logically a label.
Comment 3 Willie Walker 2009-01-21 21:25:33 UTC
(In reply to comment #2)
> Further exploration of this may lead to another bug where we don't look at
> things with DESCRIBED_BY relations in all cases.  We might need to consider
> adding the text of the things doing the describing if the text is visible on
> the screen and also also really just logically a label.

Logged as bug #568611.
Comment 4 Willie Walker 2009-01-21 21:27:20 UTC
Created attachment 126946 [details] [review]
Updated patch to resolve the problem and add a new regression test

This patch pylints and tests well.  Committed to trunk and gnome-2-24.