GNOME Bugzilla – Bug 568150
With 'Resize window on zoom', zoom focus does not work when window is of maximum size
Last modified: 2018-05-24 12:30:18 UTC
When 'Resize window on zoom' is active and one is zooming in but the window already is as big as it can be, zoom focus should work but currently doesn't. Steps to reproduce: 1. Make sure Edit -> Preferences, Image Window, Resize window on zoom is checked. 2. Open an image and zoom in so that the image window becomes of maximum size on your screen. 3. Place the cursor on an arbitrary point on the image except the point in the middle. 4. Press + to zoom in further. Actual result: The cursor is not used as zoom focus point. Expected result: The cursor to be used as zoom focus point, i.e. the pixel under the cursor remains the same also after zooming.
A fix for this will be in gimp_display_shell_scale(), currently no attempt at zoom focus is attempted if shell->display->config->resize_windows_on_zoom is TRUE. Should be pretty easy to rearrange the code to make this works, it's not trivial however (if it was then I would have fixed this already).
*** Bug 573974 has been marked as a duplicate of this bug. ***
Created attachment 166694 [details] [review] I think this patch can fix this bug.
Do we really want to add that much code for an obscure feature such as "Resize window on zoom" ? I vote for removing that feature instead. What does Peter say about this?
Review of attachment 166694 [details] [review]: Rejecting due to duplication of existing code
'Resize window on zoom' can be quite neat by itself, it's just the mix of zoom-focus that's a bit messy Not a very important bug I'd say, moving of 2.6 milestone
Martin, is 2.7 affected by this bug?
Yes
FYI, it's still the same in 2.8
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/293.