After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563401 - gconfd.c uses fsyncdata, darwin lacks
gconfd.c uses fsyncdata, darwin lacks
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
CVS HEAD
Other Mac OS
: Normal normal
: ---
Assigned To: GConf Maintainers
GConf Maintainers
: 563399 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-05 23:49 UTC by paul
Modified: 2008-12-08 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description paul 2008-12-05 23:49:40 UTC
/usr/bin/glibtool --tag=CC   --mode=link gcc  -arch ppc  -g -Wall -Wno-long-double   -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3    -arch ppc     -L/opt/local/lib -L/usr/X11R6/lib           -o gconfd-2 gconf-database.o gconfd.o  -lintl  -L/opt/local/lib -lgmodule-2.0 -lORBit-2 -lgthread-2.0 -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -lintl   libgconf-2.la 
gcc -arch ppc -g -Wall -Wno-long-double -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -arch ppc -o .libs/gconfd-2 gconf-database.o gconfd.o  -L/opt/local/lib -L/usr/X11R6/lib ./.libs/libgconf-2.4.1.5.dylib /opt/local/lib/libORBit-2.0.1.0.dylib /opt/local/lib/libgmodule-2.0.0.1903.0.dylib /opt/local/lib/libgthread-2.0.0.1903.0.dylib /opt/local/lib/libdbus-glib-1.2.1.0.dylib /opt/local/lib/libdbus-1.3.4.0.dylib /opt/local/lib/libgobject-2.0.0.1903.0.dylib /opt/local/lib/libglib-2.0.0.1903.0.dylib /opt/local/lib/libintl.8.0.2.dylib /usr/lib/libiconv.2.4.0.dylib -lc 
ld: warning multiple definitions of symbol _locale_charset
/opt/local/lib/libintl.8.0.2.dylib(localcharset.o) definition of _locale_charset
/usr/lib/libiconv.2.4.0.dylib(localcharset.o) definition of _locale_charset
ld: Undefined symbols:
_fdatasync
make[4]: *** [gconfd-2] Error 1
Comment 1 Daniel Macks 2008-12-07 07:01:09 UTC
This function call was added in response to Bug #562976, and confirming that OS X 10.4 doesn't have fdatasync (don't have 10.5 handy to check). Maybe should to an AC_CHECK_FUNCS for it, and if not available, fall back to fsync() in gconfd.c?
Comment 2 Ray Strode [halfline] 2008-12-08 15:25:47 UTC
I wouldn't bother complicating the code.  Let's just change it to fsync() unconditionally (unless we find it adversely affects performance).  No need to add complexity for a premature optimization.
Comment 3 Ray Strode [halfline] 2008-12-08 15:26:49 UTC
*** Bug 563399 has been marked as a duplicate of this bug. ***
Comment 4 Ray Strode [halfline] 2008-12-08 15:43:04 UTC
This should be good to go now.