After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563399 - Fails to compile on OSX
Fails to compile on OSX
Status: VERIFIED DUPLICATE of bug 563401
Product: GConf
Classification: Deprecated
Component: gconf
CVS HEAD
Other All
: Normal blocker
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-05 23:26 UTC by John Ralls
Modified: 2008-12-21 21:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26



Description John Ralls 2008-12-05 23:26:14 UTC
Please describe the problem:
gconfd.c calls fdatasync(int). This function is not available on OSX.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
This patch fixes the problem (and should do for any OS without fdatasync()):
===================================================================
--- configure.in        (revision 2715)
+++ configure.in        (working copy)
@@ -205,7 +205,7 @@
 
 AC_CHECK_HEADERS(syslog.h sys/wait.h)
 
-AC_CHECK_FUNCS(getuid sigaction fsync fchmod fdwalk)
+AC_CHECK_FUNCS(getuid sigaction fsync fchmod fdwalk fdatasync)
 
 
 LDAP_LIBS=
Index: gconf/gconfd.c
===================================================================
--- gconf/gconfd.c      (revision 2715)
+++ gconf/gconfd.c      (working copy)
@@ -1638,8 +1638,11 @@
 
       goto out;
     }
-
+#ifdef HAVE_FDATASYNC
   if (fdatasync (fd) < 0)
+#else
+      if (fsync (fd) < 0)
+#endif
     {
       gconf_log (GCL_WARNING,
                  _("Could not flush saved state file '%s' to disk: %s"),
Comment 1 Ray Strode [halfline] 2008-12-08 15:26:49 UTC
Another bug got filed right after this one.  Going to mark this one as a duplicate of that one, since that one has more information on the history of the bug.

*** This bug has been marked as a duplicate of 563401 ***