After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560738 - No Mac-style keyboard shortcuts
No Mac-style keyboard shortcuts
Status: RESOLVED NOTGNOME
Product: tomboy
Classification: Applications
Component: General
0.13.x
Other Mac OS
: Normal major
: 1.4.0
Assigned To: Tomboy Maintainers
Tomboy Maintainers
gnome[moved-to-github]
: 581941 598089 605679 653783 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-11-14 05:25 UTC by Alex Schearer
Modified: 2017-07-31 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alex Schearer 2008-11-14 05:25:43 UTC
Currently there aren't any toolbar shortcuts. (It looks like there are some but most likely they are just OS defaults and anyway aren't apparently being listened for.) Tomboy should implement all of the common shortcuts such as those for opening/closing windows (read notes), opening preferences, hiding the application, and quitting the application.
Comment 1 Sandy Armstrong 2008-11-14 13:38:21 UTC
You're talking about keyboard shortcuts? I think you'll find we have a lot, you just have to use ctrl instead of cmd in your key combos. But yeah, we want t support more Mac-like keyboard shortcuts.

Can you give some examples of shortcuts you expect?
Comment 2 Alex Schearer 2008-11-14 16:28:24 UTC
  * Command , should open preferences
  * Command q should quit Tomboy (but not the toolbar app)
  * Command w should close the current window
  * Command h should hide all windows
  * Command m should minimize the current window
  * Command c, x, p should copy/cut/paste (currently not present under Edit)
  * Command o should open the "Search all notes" window, I think
  * Some key should delete a note, I'm not sure what the current command is, I propose Command delete
  * Command ? should bring up help (which I don't think currently exists, so perhaps we should launch the browser?)

Those are some examples. I recognize that a lot of functionality is already present and simply mapped to ctrl - key, hopefully that won't be too hard to correct. 
Comment 3 Sandy Armstrong 2008-11-14 16:58:39 UTC
Yeah, this shouldn't be hard, but it will require some refactoring to do it nicely.
Comment 4 Sandy Armstrong 2009-05-08 22:24:14 UTC
*** Bug 581941 has been marked as a duplicate of this bug. ***
Comment 5 Sandy Armstrong 2009-10-11 16:50:43 UTC
*** Bug 598089 has been marked as a duplicate of this bug. ***
Comment 6 Sandy Armstrong 2009-10-11 16:51:33 UTC
there's a branch for this in git, btw
Comment 7 Sandy Armstrong 2010-02-23 14:51:00 UTC
*** Bug 605679 has been marked as a duplicate of this bug. ***
Comment 8 Sandy Armstrong 2010-02-23 14:52:05 UTC
We were hoping to fix this a few weeks ago by merging in some work on customizable keybindings from a contributor, but the code wasn't ready so it's been bumped to next cycle.
Comment 9 Federico Ramallo 2010-03-31 20:02:38 UTC
Hi

looks like on tomboy 1.2.0 cut/copy and paste shortcuts using ctrl key are not working anymore.
I'm using OS X 10.6.2
Could be related to this bug?
What's the current status?
Comment 10 Sandy Armstrong 2010-03-31 20:59:54 UTC
(In reply to comment #9)
> looks like on tomboy 1.2.0 cut/copy and paste shortcuts using ctrl key are not
> working anymore.

This seems to be a bug caused by the gtk+ shipped in the latest Mono installer.  I haven't had a chance to look into it, but it's pretty irritating.
Comment 11 pascal 2010-03-31 21:25:07 UTC
Tested on tomboy 1.2.0 on OS X 10.6.2 :

- Some shortcuts work as expected (e.g. cut/copy/paste are mapped to the usual cmd-X/cmd-C/cmd-V that any Mac user expects).

- Some shortcuts are still mapped to incorrect keys, like Ctrl-W to close a window (and not Cmd-W) or Ctrl-Q to quit (and not Cmd-Q).
Comment 12 Federico Ramallo 2010-03-31 23:55:23 UTC
nice! thanks for the tip Pascal!

I missed the global shortcuts, but the cut and paste are critical...

So It works with mono FW version 2.4.3, that includes:
 gtk+-2.17.9-2
 gtk-engines-2.16.1-2
 gtkrc_mac.zip

Sandy could you give me some directions on where lookup on the code to improve the shortcuts? 
I'll try to make a patch
Comment 13 Sandy Armstrong 2010-04-01 00:09:03 UTC
Federico, I am not at all familiar with gtk+ code, so you're on your own there.

If you're referring to Tomboy code, keybindings are almost entirely in NoteWindow.cs, and it has the Control key hard-coded in a lot of places.

If you're wondering where the big pending keybindings patch is that I mentioned in comment #8, well that's not posted anywhere, but hopefully the developer will continue working on it this cycle.

The reason copy/paste and a few other shortcuts might have started going from Control to Command in recent versions of Mono is because of updates to GTK+ that change the keybindings for some of the basic shortcuts in the Gtk.TextView, but of course have no effect on Tomboy's hard-coded keybindings.
Comment 14 david 2010-04-07 23:47:42 UTC
None of the cut/copy/paste shortcuts are working for me (a big issue).  That includes both the standard Ctrl+ commands, and the Mac Cmd+ versions.  I've also tried (Tomboy was tested both before and after) adding new global mappings to the ~/Library/Kebindings/DefaultKeyBindings.dict but I haven't managed to get the mappings to work in any application.  

I have a new Mac with OSX 10.6.3, Tomboy 1.2.0, and Mono 2.6.3.  I can't find the GTK version number (this is only my second day with a Mac).
Comment 15 Brion Vibber 2010-04-20 00:04:01 UTC
I can confirm the failures David's seeing: neither ctrl nor cmd shortcuts work for cut and paste, which makes it incredibly difficult to actually use Tomboy 1.2.0 on the Mac (OS X 10.6.3, Mono 2.6.3.)

This is a serious usability problem. Fortunately the the cut-and-paste context menu items *do* work, but it's pretty awkward... Most other shortcuts seem to still work with control.

Same problems seen building Tomboy fresh from git master.
Comment 16 Federico Ramallo 2010-04-20 00:29:33 UTC
in order to fix the shortcut issues please install older Mono version.

http://ftp.novell.com/pub/mono/archive/2.4.3/download/

the gtk version is bundled inside, i don't know the version.

enjoy!
Comment 17 Brion Vibber 2010-04-20 09:32:05 UTC
Do we know what the problem is on the Gtk+ or Gtk# side? I'd be happy to poke at it on that end (trapped abroad due to volcano, lots of free time!)
Comment 18 Sandy Armstrong 2010-04-20 13:04:50 UTC
Hi Brion.  As I mentioned in comment #6, I thought I had this pretty much figured out in a branch in gnome git.  But now with the new GTK+ I'm not sure what the right way to do anything is.

I'd recommend taking a look at MonoDevelop's codebase to see what they do, since GTK+ on Mono on Mac is pretty much only ever tested with MD before a release :-P

I'd appreciate any work on this, as I simply haven't had any time to touch my Mac in the past few weeks.  I'm sure the many people affected by this bug would also love to see any fix. :-)  Yay natural disasters!
Comment 19 david 2010-04-20 14:03:42 UTC
I can confirm that installing the older GTK version Federico recommends restores copy/paste functionality using the Mac Cmd shortcuts -- thanks!


It seems like except for the clipboard functions using the Cmd+ shortcuts, everything else uses the standard [everywhere-but-mac] Ctrl+ shortcuts.  Ideally, it would be great if you guys can figure out how to get it to accept both the Cmd+ and the Ctrl+ shortcuts for all of the commands.
Comment 20 Sandy Armstrong 2010-04-20 14:06:21 UTC
Actually, I'd prefer to use entirely mac-style keyboard shortcuts.  I don't think it makes sense to support ctrl+ once cmd+ is working.
Comment 21 david 2010-04-20 14:33:13 UTC
Ok, the ideal solution then would be to make it an option in the preferences ;-)

I prefer both because I'm still learning Mac shortcuts, and [more importantly] switching back and forth between the Mac, a Windows Laptop, and several remote machines via VNC/RDC from the Mac.  Suffice it to say, remembering when to use the Mac shortcuts gets quite confusing quite quickly.  Particularly when it comes to the remote systems where sometimes RDC/VNC will translate Mac shortcuts, and sometimes it won't -- I'm just thankful that at least the home/end keys behave sanely in Tomboy by default ... but now I"m just wandering off topic.
Comment 22 Sandy Armstrong 2010-04-20 17:11:37 UTC
(In reply to comment #21)
> Ok, the ideal solution then would be to make it an option in the preferences
> ;-)

I've mentioned before some pending work on customizable keybindings.  I think that would be the proper way to address this kind of preference.  Until it lands, though, I think we should just aim for fitting in on the Mac.
Comment 23 jfontana 2010-05-24 16:55:27 UTC
I can confirm that cut-copy-paste through the command (or Ctrl) keys is not working in 10.6.3. I would prefer not to have to uninstall the current version of Mono.

JM
Comment 24 Sandy Armstrong 2011-06-30 22:56:34 UTC
*** Bug 653783 has been marked as a duplicate of this bug. ***
Comment 25 Sandy Armstrong 2011-06-30 22:58:08 UTC
BTW, here is the commit where I had played around with fixing this, though I did not complete the work and I'd still prefer an approach where all keybindings are completely customizable:

http://git.gnome.org/browse/tomboy/commit/?h=mac-keybindings&id=fc2f34ca940335cb99a95c8d8ce06005be7e2a2a
Comment 26 papashou 2011-06-30 23:13:02 UTC
I like the idea of customizable keybindings, but I think also some work needs to go into adopting some of the Mac-ish ways of doing things (e.g. Command+Arrow would jump to beginning or EOL),  Command+Tilde(backtick) typically cycles through all windows of the same application.  Some of the window management options need to be a little more Mac-ish too, such as NOT remembering the last position and size of the window and instead creating the window on top of the existing ones [perhaps offer an option to disable remembering].  It plays evil games with Expose-- if you move a note into say, desktop 4... and then, close it.. go to Desktop 1 and re-open that note, you get shifted to Desktop 4 with that note (which just confuses me with the way I expect things to work). 

I'm no developer but is it possible to see some more activity for Tomboy on Mac OSX?
Comment 27 Sandy Armstrong 2011-06-30 23:34:29 UTC
papashou, thanks for the feedback.

Yes, absolutely, by default the Mac needs Macish shortcuts.  I'm just saying that the "right" way to do it is to make all of our keybindings customizable, but we should provide schemas for each platform so that customizing them is not necessary from the get-go.

The other behaviors should be filed as separate bugs.  I'm not sure if anybody is actively developing on OS X right now, so the only way to see things improve at the pace you want is to send patches (if you can file a bug you can learn to code!) or pay somebody to send them for you.
Comment 28 papashou 2011-06-30 23:42:18 UTC
(In reply to comment #27)

> if you can file a bug you can learn to code!

I wouldn't know the first thing to do about getting started with building Tomboy, etc!
Comment 29 Sandy Armstrong 2011-07-01 01:34:18 UTC
https://live.gnome.org/Tomboy/Building/Mac

:-P
Comment 30 QA 2014-01-29 01:47:49 UTC
When I use my computer I like to get things done quickly. Shortcuts help me do this. There are some shortcuts I use in every application and therefor expect to work universally. [Cmd H] to Hide and [Cmd ,] for application Preferences are two examples.

The other day I went to access GIMP's Preferences and (tap, tap, tap...) it doesn't work! Some people didn't care enough to program a standard shortcut. 
*sad face*
Or worse, someone may have removed some standard shortcuts. Because I'm pretty sure when you compile a Mac application those shortcuts are set as default.

Even the most basic Mac software adheres to this convention. For example I have an app called NameChanger and its only purpose is to batch-rename files, but even this simple app includes the expected Mac shortcuts. Certainly a graphics manipulation app would be expected to include this basic functionality.

Take another example, Blender. Its interface is completely custom and specific to Blender. Yet even being as such, its Mac version keeps convention with shortcuts for Hide, Preferences, Cut/Copy/Paste, Save, Quit, etc.

The most shocking thing however, is that this was first reported in 2008 and it is now 2014!
Comment 31 QA 2014-01-29 02:16:34 UTC
Shit, sorry! I thought this was the GIMP section because gimp.org directed me here. 
And Bugzilla offers no way to browse by software title. All titles are lumped together apparently.
When I searched for "mac shortcuts" I thought I was searching within the context of GIMP.
Please disregard my previous post.
Comment 32 André Klapper 2017-07-31 12:47:15 UTC
The Tomboy team has moved from GNOME Bugzilla to GitHub for bug reports and feature requests: 
      https://github.com/tomboy-notes/tomboy/issues/
Closing this report as NOTGNOME as part of Bugzilla Housekeeping (bug 781054) to keep tasks in one place. Please feel free to transfer this task to GitHub if this task is still valid in a recent Tomboy version. 
We are sorry for the inconvenience.