After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557184 - use preview::icon to speed up thumnailing
use preview::icon to speed up thumnailing
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on: 557182
Blocks:
 
 
Reported: 2008-10-21 05:38 UTC by David Zeuthen (not reading bugmail)
Modified: 2008-10-21 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.52 KB, patch)
2008-10-21 05:39 UTC, David Zeuthen (not reading bugmail) 		none Details | Review

Description David Zeuthen (not reading bugmail) 2008-10-21 05:38:20 UTC 
Bug 557182 introduces a new preview::icon file attribute to get thumbnails directly from a device. This is interesting for the gphoto2 backend as it will speed up thumbnailing by a couple of orders of magnitudes (e.g. 10-100 times faster).

Also, it seems trunk is busted, at least you want this hunk

 -    if (result) {
 +
 +    if (!result) {

otherwise thumbnailing won't work at all.
Comment 1 David Zeuthen (not reading bugmail) 2008-10-21 05:39:19 UTC 
Created attachment 120988 [details] [review]
proposed patch
Comment 2 Alexander Larsson 2008-10-21 13:05:53 UTC 
commited.